-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GiottoClass v0.4.0 #241
Merged
GiottoClass v0.4.0 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pip_packages param to allow repository selection when install conda env
Fix functions to be generalizable for more datasets
Mainly an order of operations kind of issue that violated the hierarchical checking
- TODO also deprecate the multomics internals
- remove package self reference with `GiottoClass::` - Use `setGiotto()` generic which will automatically loop over list inputs
- allow hierarchical slot checks to be turned off. - ... arg is needed so that `setGiotto()`can pass `check_preqs` arg without erroring because the underlying accessor does not have that arg.
- allow creation of a `giotto` object without going through the full initialization workflow - add a debug message for when initialization is run.
feat: `[` and `subset()` for `giotto`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking changes
minCircle()
bug fixes
dimnames()
for some subobjectsjoinGiottoObject()
for gobjects with only poly and point data #233joinGiottoObject()
for gobjects with image intensity overlaps featuresmatrix
drop tonumeric
when only one cell is leftshift_vertical_step
andshift_horizontal_step
args increateGiottoPolygonsFromMask()
when numeric now shift by steps based on the dims of the image instead of just by the numerical value provided.subsetGiottoLocs()
giottoAffineImage
loading after being savedenhancements
installGiottoEnvironment()
#224giotto
initialize()
and slot checking behavior can be toggled now using'giotto.init'
and'giotto.check_valid'
options. #946 by rbutleriiisetGiotto()
now only initializes and performs checks once all items are added if alist
input is provided.instructions()
with no args will now callcreateGiottoInstructions()
. You can also supply named args.instructions(gobject, param)
andinstructions(gobject, param)<-
will now work forgiottoInstructions
objects for convenience.[
,[[
,$
,$<-
, andsubset()
forgiotto
see?GiottoClass::subset_giotto
subset
forspatIDs()
andfeatIDs()
objName()
,spatUnit()
,featType()
generics now returnNA_character_
instead of erroring when used on unsupported classes.ext()
andext<-()
can now be used to get and set extent ofaffine2d
rownames()
,colnames()
,dimnames()
forgiotto
spatValues()
can get values from multiple spatial units.createGiottoPolygonsFromMask()
now works with anythingterra::rast()
can readcreateGiottoLargeImage()
now works with anythingterra::rast()
can readnew
sliceGiotto()
for pulling out specific spatial units and feature types as independentgiotto
objectssplitGiotto()
for splitting a Giotto object into a list of Giotto objects based on a cell metadata columnas.list()
method forgiotto
to dump the data as a list of subobjectsXY()
andXY<-()
for accessing and setting coordinate values of subobjects asmatrix
convHull()
,minRect()
,minCircle()
for Giotto spatial vector classesarea()
forSpatVector
andgiottoPolygon