-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Lidl/Silvercrest door bell (TS0211) #4282
Add support for Lidl/Silvercrest door bell (TS0211) #4282
Conversation
Linked the issue on PR. |
c7c1099
to
64eb98e
Compare
@manup Is there anything I can do to get this merged? I don't really like that we need to allowlist all the separate mac prefixes, can we improve that somehow? |
@jurriaan Feel free to compile yourself :) Having the whitelist enables Dresden-Elektronik to keep control and have some quality assurance so that every device works. Otherwise, we would be getting flooded with "Device doesn't work" requests. So i do understand your frustration, but at this point they are in no position to simplyfy it afaik. |
There are quite some device requests which didn't made it into v2.9.2 since releases after x.y.0 are meant to prepare for stable release. I think this one here is safe to include in the next v2.10.0 beta release where new devices get merged. |
Thanks for the response, I'm running deconz with this change for almost two weeks already, it's working perfectly.
Was just asking this in case you want me to improve something before this can be merged :)
|
9213377
to
5318518
Compare
Can you please sync the PR with latest master for merging. In a followup PR it would be good to replace the model id (TS0211) with a unique product id, see #4377 for an example how it works for other Tuya devices. |
5318518
to
c2def06
Compare
Rebased on master, will do a followup to fix that :) |
@manup I just looked into it and was a bit confused, I noticed that in de_web_plugin.cpp there is a lidlDevice list as well. How does this work exactly. Lidl devices are Tuya devices (mostly?) should those tables be integrated into one? They seem to serve a similar purpose. |
Is that only a button? https://zigbee.blakadder.com/Lidl_HG06668.html Not sure I got the right one here. |
Yes, that's the one |
Hello |
Adds support for the new door bell device, which shows up as a IAS Zone 'Contact Switch' device.
After these changes deconz emits the correct events, but it doesn't show up in Phoscon, is that expected behavior?