Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Lidl/Silvercrest door bell (TS0211) #4282

Conversation

jurriaan
Copy link
Contributor

Adds support for the new door bell device, which shows up as a IAS Zone 'Contact Switch' device.

After these changes deconz emits the correct events, but it doesn't show up in Phoscon, is that expected behavior?

@Mimiix Mimiix linked an issue Feb 1, 2021 that may be closed by this pull request
@Mimiix
Copy link
Collaborator

Mimiix commented Feb 1, 2021

Linked the issue on PR.

@jurriaan jurriaan force-pushed the add-lidl-silvercrest-door-bell-support branch from c7c1099 to 64eb98e Compare February 1, 2021 10:40
@jurriaan
Copy link
Contributor Author

jurriaan commented Feb 8, 2021

@manup Is there anything I can do to get this merged?

I don't really like that we need to allowlist all the separate mac prefixes, can we improve that somehow?

@Mimiix
Copy link
Collaborator

Mimiix commented Feb 8, 2021

@jurriaan Feel free to compile yourself :) Having the whitelist enables Dresden-Elektronik to keep control and have some quality assurance so that every device works. Otherwise, we would be getting flooded with "Device doesn't work" requests. So i do understand your frustration, but at this point they are in no position to simplyfy it afaik.

@manup manup added this to the v2.10.0-beta milestone Feb 8, 2021
@manup
Copy link
Member

manup commented Feb 8, 2021

There are quite some device requests which didn't made it into v2.9.2 since releases after x.y.0 are meant to prepare for stable release. I think this one here is safe to include in the next v2.10.0 beta release where new devices get merged.

@jurriaan
Copy link
Contributor Author

jurriaan commented Feb 8, 2021 via email

@jurriaan jurriaan force-pushed the add-lidl-silvercrest-door-bell-support branch from 9213377 to 5318518 Compare February 10, 2021 22:45
@manup
Copy link
Member

manup commented Feb 15, 2021

Can you please sync the PR with latest master for merging.

In a followup PR it would be good to replace the model id (TS0211) with a unique product id, see #4377 for an example how it works for other Tuya devices.

@jurriaan jurriaan force-pushed the add-lidl-silvercrest-door-bell-support branch from 5318518 to c2def06 Compare February 15, 2021 14:55
@jurriaan
Copy link
Contributor Author

Rebased on master, will do a followup to fix that :)

@manup manup merged commit 73e4ffc into dresden-elektronik:master Feb 15, 2021
@jurriaan
Copy link
Contributor Author

@manup I just looked into it and was a bit confused, I noticed that in de_web_plugin.cpp there is a lidlDevice list as well.

See https://github.com/dresden-elektronik/deconz-rest-plugin/blob/master/de_web_plugin.cpp#L463-L479

How does this work exactly. Lidl devices are Tuya devices (mostly?) should those tables be integrated into one? They seem to serve a similar purpose.

@jurriaan jurriaan deleted the add-lidl-silvercrest-door-bell-support branch February 15, 2021 21:10
@MattL0
Copy link

MattL0 commented Feb 15, 2021

Is that only a button? https://zigbee.blakadder.com/Lidl_HG06668.html

Not sure I got the right one here.

@jurriaan
Copy link
Contributor Author

Yes, that's the one

@mohdshaqdih
Copy link

Hello
Do you have edge drive for Lidl doorbell
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEVICE REQUEST] SilverCrest doorbell
6 participants