Multiple bug fixes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Batcastle
commented
Nov 26, 2021
Batcastle
commented
- fixed GRUB installation bug (BIOS installation fails #52)
- some code clean up
- documentation improvments
incorporates eprint function so multiple files can use it and we can change the function, if necessary, in one location.
imported si-utilities removed eprint function from file changed eprint calls to si-utilties.eprint
removed eprint from UI --> main.py since it was moved to a utilities file
So it can be properly imported to main.py file
si_utilities symlink was incorrectly named
added python3-parted dependency
with python3-gnupd
this functionality is handled by common.py
this functionality is handled by common.py
In UI main.py, replaced references to si-utilities with common
Remove duplicate code, use `common` lib
removed si-utilities.py from roadmap
Added more content to the developer documentation
The top message in the manual partitioner duplicated code in multiple places. I consolidated it into one function.
Update development documentation
Batcastle
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.