Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #47

Merged
merged 14 commits into from
Oct 29, 2021
Merged

Dev #47

merged 14 commits into from
Oct 29, 2021

Conversation

SenlisO
Copy link
Member

@SenlisO SenlisO commented Oct 28, 2021

Created si_utilities.py that contains eprint function.

Created si_utilities.py symlink into UI folder

Updated UI main.py file to use eprint from si_utilities module.

These changes have been tested.

incorporates eprint function so multiple files can use it and we can change the function, if necessary, in one location.
imported si-utilities
removed eprint function from file
changed eprint calls to si-utilties.eprint
removed eprint from UI --> main.py since it was moved to a utilities file
So it can be properly imported to main.py file
si_utilities symlink was incorrectly named
added python3-parted dependency
with python3-gnupd
@pep8speaks
Copy link

pep8speaks commented Oct 28, 2021

Hello @SenlisO! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 34:1: E402 module level import not at top of file
Line 35:1: E402 module level import not at top of file
Line 37:1: E302 expected 2 blank lines, found 1
Line 60:80: E501 line too long (80 > 79 characters)
Line 62:80: E501 line too long (82 > 79 characters)
Line 111:80: E501 line too long (80 > 79 characters)
Line 121:80: E501 line too long (80 > 79 characters)
Line 124:80: E501 line too long (80 > 79 characters)
Line 127:80: E501 line too long (83 > 79 characters)
Line 154:80: E501 line too long (98 > 79 characters)
Line 467:80: E501 line too long (84 > 79 characters)
Line 508:80: E501 line too long (80 > 79 characters)
Line 549:80: E501 line too long (82 > 79 characters)
Line 575:80: E501 line too long (84 > 79 characters)
Line 658:80: E501 line too long (85 > 79 characters)
Line 674:80: E501 line too long (80 > 79 characters)
Line 706:80: E501 line too long (80 > 79 characters)
Line 715:80: E501 line too long (91 > 79 characters)
Line 789:80: E501 line too long (85 > 79 characters)
Line 796:80: E501 line too long (81 > 79 characters)
Line 802:80: E501 line too long (90 > 79 characters)
Line 812:80: E501 line too long (98 > 79 characters)
Line 835:80: E501 line too long (85 > 79 characters)
Line 856:80: E501 line too long (96 > 79 characters)
Line 903:80: E501 line too long (92 > 79 characters)
Line 904:80: E501 line too long (94 > 79 characters)
Line 905:80: E501 line too long (128 > 79 characters)
Line 951:5: E303 too many blank lines (2)
Line 974:80: E501 line too long (90 > 79 characters)
Line 992:80: E501 line too long (82 > 79 characters)
Line 1021:5: E303 too many blank lines (2)
Line 1054:5: E303 too many blank lines (2)
Line 1183:80: E501 line too long (94 > 79 characters)
Line 1203:80: E501 line too long (125 > 79 characters)
Line 1223:16: E126 continuation line over-indented for hanging indent
Line 1224:16: E126 continuation line over-indented for hanging indent
Line 1306:80: E501 line too long (86 > 79 characters)
Line 1307:80: E501 line too long (117 > 79 characters)
Line 1314:80: E501 line too long (116 > 79 characters)
Line 1315:80: E501 line too long (129 > 79 characters)
Line 1328:80: E501 line too long (129 > 79 characters)
Line 1335:80: E501 line too long (128 > 79 characters)
Line 1408:80: E501 line too long (81 > 79 characters)
Line 1492:80: E501 line too long (83 > 79 characters)
Line 1558:32: E128 continuation line under-indented for visual indent
Line 1558:32: W503 line break before binary operator
Line 1582:80: E501 line too long (93 > 79 characters)
Line 1682:5: E303 too many blank lines (2)
Line 1706:5: E303 too many blank lines (2)
Line 1717:13: E124 closing bracket does not match visual indentation
Line 1718:18: E124 closing bracket does not match visual indentation
Line 1719:23: E124 closing bracket does not match visual indentation
Line 1720:28: E124 closing bracket does not match visual indentation

Comment last updated at 2021-10-29 00:12:32 UTC

@Batcastle Batcastle self-assigned this Oct 28, 2021
@Batcastle Batcastle added the enhancement New feature or request label Oct 28, 2021
this functionality is handled by common.py
this functionality is handled by common.py
In UI main.py, replaced references to si-utilities with common
@SenlisO
Copy link
Member Author

SenlisO commented Oct 29, 2021

removed si_utilities files and used common for main.py instead.

@Batcastle Batcastle merged commit e4be2d1 into drauger-os-development:dev Oct 29, 2021
removed si-utilities.py from roadmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants