Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(v2): remove test runner; introduce test doubles #132

Merged
merged 71 commits into from
Apr 16, 2022
Merged

BREAKING(v2): remove test runner; introduce test doubles #132

merged 71 commits into from
Apr 16, 2022

Conversation

ebebbington
Copy link
Member

@ebebbington ebebbington commented Oct 25, 2021 •
edited by crookse
Loading

:(

Release Notes

  • BREAKING: remove test runner (Rhum.testPlan, Rhum.testSuite, Rhum.testCase, and hooks)
  • BREAKING: stub API (no need to stub a class to stub its members)
  • feat: add Fake()
  • feat: add Dummy()
  • feat: Add new methods to Mock()
    • expects(...).toBeCalled(...)
    • method(...).willReturn(...)
    • method(...).wilThrow(...)
    • verifyExpectations()
  • feat: pre-programmed method implementation for faking/mocking methods
    • this is used to help fakes take shortcuts
    • this is used to help mocks pre-program methods
  • feat: add interfaces so that they can be returned for improved type hinting
  • feat: build for cjs and es2015
  • refactor: mocks to use mixin (mocks are now extensions of the class they are mocking)
  • refactor: types are now stricter and provide better type hinting
  • test: move integration test files into unit tests
  • test: test fakes, dummies, mocks, and stubs

@ebebbington ebebbington added the Type: Major Merging this pull request results in a major version increment label Oct 25, 2021
@ebebbington ebebbington requested a review from crookse October 25, 2021 21:39
This was linked to issues Oct 25, 2021
Rhum.only() #5
Closed
Rhum v2.0 (Release Date: TBD) #75
Closed
Cannot use a tsconfig.json with Rhum #103
Closed
Turn rhum into purely a mocking module #121
Closed
After hooks aren't ran if test case fails #125
Closed
@crookse crookse mentioned this pull request Nov 27, 2021
Closed
Guergeiro
Guergeiro approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@Guergeiro Guergeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad 😢

crookse and others added 22 commits April 14, 2022 22:11
@crookse
chore: yarn.lock
4824acc
@crookse
chore: move deno unit tests to tests/deno
75c112a
@crookse
fix: issue with compiling down
63057b5
@crookse
test: cjs tests
1f9f95f
@crookse
fix: issue with erratic builds
6b0d6cc
@crookse
fix: issue with testing esm
79c26a2
@crookse
chore: remove test for protected methods (should not do this)
5f5458d
@crookse
test: esm tests
b82f72c
@crookse
chore: remove yarn.lock
1f11a36
@crookse
Merge pull request #157 from drashland/feat/rhum-v2-node-browser-support
f41f68a 
feat(v2): support node
@crookse
Merge branch 'main' into breaking-remove-runner
0af2223
@crookse
ci: add node unit tests
631c18a
@crookse
chore: deno fmt
6b1006e
@crookse
ci: fix unit test runs for deno
b6656b0
@crookse
fix: tsconfig to point to include conversion workspace dir
580c2b0
@crookse
chore: deno fmt
e2b82d7
@crookse
chore: alphabetize scripts; add script to check build
899c364
@crookse
chore: deno fmt node config files
8ee1878
@crookse
ci: install node.. duh
1254456
@crookse
ci: remove node 10 and 12
f6db265
@crookse
ci: add deno to tests_node (required for building cjs and esm)
b677420
@crookse
ci: fix scripts to work in powershell
567de91
@crookse crookse force-pushed the breaking-remove-runner branch from a7795f9 to 44d47d1 Compare April 16, 2022 11:40
@crookse crookse force-pushed the breaking-remove-runner branch from 44d47d1 to a9b4bbe Compare April 16, 2022 11:42
@crookse crookse merged commit 17fb6ea into main Apr 16, 2022
@crookse crookse deleted the breaking-remove-runner branch April 16, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guergeiro Guergeiro Guergeiro approved these changes

@crookse crookse crookse approved these changes

Assignees
No one assigned
Labels
Type: Major Merging this pull request results in a major version increment
Milestone
No milestone
3 participants
@ebebbington @crookse @Guergeiro