Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhum.only() #5

Closed
ebebbington opened this issue Jun 19, 2020 · 2 comments · Fixed by #132
Closed

Rhum.only() #5

ebebbington opened this issue Jun 19, 2020 · 2 comments · Fixed by #132
Assignees

Comments

@ebebbington
Copy link
Member

ebebbington commented Jun 19, 2020

What

Develop the following method:

  • Rhum.only

Method should be public and should tell Rhum to only run that test plan/suite/case under the parent. For example:

  • If 1 suite of 2 is set to only under a plan, then the suite that doesnt have only should be skipped

Why
This is a testing framework dammit!

Checklist

  • Update README where needed

  • Unit & integration tests

Resources

Use the following issue as a guideline if possible

Pseudo-code for Implementation

All we have for information at the moment

Needs to account for plan/suite/case, and Rhum/RhumRunner should know that there is only one to test

Rhum.only: function (name: string, fn: Function) {
}
@ebebbington
Copy link
Member Author

Might be easier to think of an implementation once #10 is closed, as that PR collects all tests before running them - so we could just check if any of the tests have only set or something then only run that test

Note though that i think it would have to apply to all tests in a suite (if the suite has .only)?

@crookse
Copy link
Member

crookse commented Jun 22, 2020

I agree. Let's wait for #10. Yea if a test suite has .only, then it would apply to all test cases in that suite.

ebebbington pushed a commit that referenced this issue Aug 24, 2020
ebebbington pushed a commit that referenced this issue Aug 24, 2020
ebebbington pushed a commit that referenced this issue Sep 23, 2020
@ebebbington ebebbington self-assigned this Sep 28, 2020
@crookse crookse added the v2 label Oct 20, 2020
@crookse crookse changed the title Only feat: Rhum.only() Oct 31, 2020
@crookse crookse changed the title feat: Rhum.only() Rhum.only() Nov 1, 2020
@ebebbington ebebbington removed their assignment Nov 7, 2020
@ebebbington ebebbington linked a pull request Nov 7, 2020 that will close this issue
@crookse crookse self-assigned this Dec 19, 2020
@ebebbington ebebbington linked a pull request Oct 25, 2021 that will close this issue
@crookse crookse closed this as completed Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants