Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ratelimit #1391

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix ratelimit #1391

merged 1 commit into from
Jun 16, 2022

Conversation

1037husterljx
Copy link
Contributor

@1037husterljx 1037husterljx commented Jun 16, 2022

Signed-off-by: ljx373327 [email protected]

fix dfget limit flag err

Description

limit flag can't use because deserialization failed

Related Issue

#1377

Motivation and Context

  • fix failed to deserialize because of rate limit type error, replace with rate limit wrapper class
  • fix flag limit and the keyword ratelimit do not match

Screenshots (if appropriate)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@1037husterljx 1037husterljx requested a review from a team as a code owner June 16, 2022 06:28
@codecov-commenter
Copy link

Codecov Report

Merging #1391 (b0fbfe9) into main (afbd928) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   45.76%   45.39%   -0.38%     
==========================================
  Files         140      140              
  Lines       12035    12053      +18     
==========================================
- Hits         5508     5471      -37     
- Misses       5900     5952      +52     
- Partials      627      630       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.39% <0.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/dfget.go 29.06% <ø> (ø)
client/dfget/dfget.go 13.18% <0.00%> (ø)
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
client/daemon/upload/upload_manager.go 51.56% <0.00%> (-5.34%) ⬇️
client/daemon/peer/piece_downloader.go 42.18% <0.00%> (-4.19%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 45.45% <0.00%> (-1.30%) ⬇️
client/daemon/peer/peertask_conductor.go 57.14% <0.00%> (-1.01%) ⬇️
client/daemon/daemon.go 5.45% <0.00%> (-0.25%) ⬇️
client/config/peerhost.go 33.21% <0.00%> (ø)
cdn/supervisor/progress/progress.go 96.87% <0.00%> (+6.25%) ⬆️

client/config/dfget_darwin.go Outdated Show resolved Hide resolved
client/config/dfget_linux.go Outdated Show resolved Hide resolved
Signed-off-by: ljx373327 <[email protected]>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 2b42308 into dragonflyoss:main Jun 16, 2022
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants