Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfget --limit doesn't work #1377

Closed
ismewen opened this issue Jun 13, 2022 · 3 comments · Fixed by #1392
Closed

dfget --limit doesn't work #1377

ismewen opened this issue Jun 13, 2022 · 3 comments · Fixed by #1392
Assignees
Milestone

Comments

@ismewen
Copy link

ismewen commented Jun 13, 2022

Bug report:

dfget --limit doesn't work, the download speed does not follow the specified speed。

Expected behavior:

The download speed follow the specified speed

How to reproduce it:

./dfget --limit 1G -u http://10.190.113.78:8001/1gfile.tgz -b
./dfget --limit 10M -u http://10.190.113.78:8001/1gfile.tgz -b
image

Environment:

  • Dragonfly version: 2.0.3
  • OS: centos
  • Kernel (e.g. uname -a): SMP Wed Sep 29 11:01:45 CST 2021 x86_64 x86_64 x86_64 GNU/Linux
  • Others:
@1037husterljx 1037husterljx self-assigned this Jun 14, 2022
@1037husterljx
Copy link
Contributor

1037husterljx commented Jun 14, 2022

image
flag and config do not agree on the name, so the limit is not passed in
I will fix it

@1037husterljx
Copy link
Contributor

  • The command line flag limit should be ratelimit
  • ratelimit deserialization failed, change type to solve
  • When ratelimit limit is too low, below the download size of the slice, otherwise it will fail back to the source
  • The ratelimit rate described by -b is limited and cannot describe the speed limit of p2p network

@1037husterljx 1037husterljx mentioned this issue Jun 16, 2022
8 tasks
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 16, 2022
@gaius-qi
Copy link
Member

gaius-qi commented Jun 16, 2022

  • The command line flag limit should be ratelimit
  • ratelimit deserialization failed, change type to solve
  • When ratelimit limit is too low, below the download size of the slice, otherwise it will fail back to the source
  • The ratelimit rate described by -b is limited and cannot describe the speed limit of p2p network

Thx @1037husterljx 🐂🐂🐂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants