Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scheduler limit tree depth #1099

Merged
merged 1 commit into from
Feb 28, 2022
Merged

feat: scheduler limit tree depth #1099

merged 1 commit into from
Feb 28, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 28, 2022

Signed-off-by: Gaius [email protected]

Description

  • Scheduler limit tree depth.

Related Issue

Fixes #1100

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi requested a review from a team as a code owner February 28, 2022 04:20
@gaius-qi gaius-qi self-assigned this Feb 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #1099 (193ab2d) into main (ded3174) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
+ Coverage   45.35%   45.43%   +0.07%     
==========================================
  Files         130      130              
  Lines        9906     9916      +10     
==========================================
+ Hits         4493     4505      +12     
+ Misses       4888     4887       -1     
+ Partials      525      524       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.43% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/peer.go 76.39% <100.00%> (+2.37%) ⬆️
scheduler/scheduler/scheduler.go 89.28% <100.00%> (+0.23%) ⬆️

@gaius-qi gaius-qi force-pushed the feature/limit-tree-depth branch from 9823872 to 7a79317 Compare February 28, 2022 04:39
jim3ma
jim3ma previously approved these changes Feb 28, 2022
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero merged commit b93e9b0 into main Feb 28, 2022
@yxxhero yxxhero deleted the feature/limit-tree-depth branch February 28, 2022 07:04
gaius-qi added a commit that referenced this pull request Feb 28, 2022
gaius-qi added a commit that referenced this pull request Feb 28, 2022
* feat: optimize depth limit func (#1099)

Signed-off-by: Gaius <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: optimize depth limit func (#1099)

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traversing the tree consumes too much CPU resources
5 participants