feat: optimize depth limit func (#1102)

* feat: optimize depth limit func (#1099) Signed-off-by: Gaius <[email protected]>
dragonflyoss · Feb 28, 2022 · caa59e4 · caa59e4
1 parent 892f9a3
commit caa59e4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/scheduler/resource/peer.go b/scheduler/resource/peer.go
@@ -310,9 +310,6 @@ func (p *Peer) ReplaceParent(parent *Peer) {
 
 // Depth represents depth of tree
 func (p *Peer) Depth() int {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-
 	node := p
 	var depth int
 	for node != nil {

diff --git a/scheduler/scheduler/scheduler.go b/scheduler/scheduler/scheduler.go
@@ -253,8 +253,9 @@ func (s *scheduler) filterParents(peer *resource.Peer, blocklist set.SafeSet) []
 			return true
 		}
 
-		if parent.Depth() > defaultDepthLimit {
-			peer.Log.Infof("exceeds the %d depth limit of the tree", defaultDepthLimit)
+		depth := parent.Depth()
+		if depth > defaultDepthLimit {
+			peer.Log.Infof("%d exceeds the %d depth limit of the tree", depth, defaultDepthLimit)
 			return true
 		}