Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

feature: add gc disks metrics #966

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

yeya24
Copy link
Collaborator

@yeya24 yeya24 commented Sep 25, 2019

Signed-off-by: yeya24 [email protected]

Ⅰ. Describe what this PR did

Add metrics about disk gc

Ⅱ. Does this pull request fix one issue?

Fixes #958

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

I think we should consider opening a new PR for the whole tests of supernode gc.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @yeya24
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@yeya24 yeya24 changed the title add gc disks metrics feature: add gc disks metrics Sep 25, 2019
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #966 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   46.48%   46.48%           
=======================================
  Files         116      116           
  Lines        6908     6908           
=======================================
  Hits         3211     3211           
  Misses       3440     3440           
  Partials      257      257
Impacted Files Coverage Δ
supernode/config/config.go 72.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc8da9...16de4be. Read the comment docs.

@starnop
Copy link
Contributor

starnop commented Sep 26, 2019

LGTM. And I think we should merge the PR #963 firstly. 😄

@starnop
Copy link
Contributor

starnop commented Sep 26, 2019

I think we should consider opening a new PR for the whole tests of supernode gc.

That's right. And could you please open an issue to record that? THX

Signed-off-by: yeya24 <[email protected]>
@yeya24 yeya24 reopened this Sep 26, 2019
@starnop starnop merged commit 4e2518c into dragonflyoss:master Sep 27, 2019
@yeya24 yeya24 deleted the feature/gc-metrics branch September 27, 2019 02:35
starnop added a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Help wanted] add metrics for gc disk
4 participants