This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
docs: update the metrics as a table #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SataQiu
force-pushed
the
improve-docs-20190925
branch
from
37807e6 to
8e23995
Compare
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
=======================================
Coverage 46.48% 46.48%
=======================================
Files 116 116
Lines 6908 6908
=======================================
Hits 3211 3211
Misses 3440 3440
Partials 257 257
Continue to review full report at Codecov.
|
|
Could you please add a column in the table and stuff metrics type into it? |
SataQiu
force-pushed
the
improve-docs-20190925
branch
from
8e23995 to
17f2aa8
Compare
Sure! Done. |
starnop
reviewed
Sep 25, 2019
docs/user_guide/metrics.md
Outdated
| - dragonfly_supernode_pieces_downloaded_size_bytes_total{} - total size of pieces downloaded from supernode in bytes. counter type. | ||
| - dragonfly_supernode_gc_peers_total{} - total number of peers that have been garbage collected. counter type. | ||
| - dragonfly_supernode_gc_tasks_total{} - total number of tasks that have been garbage collected. counter type. | ||
| Name | Type | Description |
There was a problem hiding this comment.
So embarrassed. 😢 And could you please add a column in the table and stuff labels into it?
yeya24
suggested changes
Sep 25, 2019
docs/user_guide/metrics.md
Outdated
| - dragonfly_supernode_gc_tasks_total{} - total number of tasks that have been garbage collected. counter type. | ||
| Name | Type | Description | ||
| :----------------------------------------------------------------------- | :-------- | :---------- | ||
| dragonfly_supernode_build_info{version, revision, goversion, arch, os} | gauge | build and version information of supernode. |
There was a problem hiding this comment.
I hope we can separate the metric name and its labels. So please add another column called labels
yeya24
suggested changes
Sep 25, 2019
docs/user_guide/metrics.md
Outdated
| Name | Type | Description | ||
| :----------------------------------------------------------------------- | :-------- | :---------- | ||
| dragonfly_supernode_build_info{version, revision, goversion, arch, os} | gauge | build and version information of supernode. | ||
| dragonfly_supernode_http_requests_total{code, handler, method} | counter | total number of http requests. |
There was a problem hiding this comment.
Please capitalize all these metrics description sentences.
Signed-off-by: SataQiu <[email protected]>
SataQiu
force-pushed
the
improve-docs-20190925
branch
from
0b49dca to
0b9b2ac
Compare
yeya24
approved these changes
Sep 26, 2019
|
LGTM. Good job. THX. |
starnop
added a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
docs: update the metrics as a table
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
docs: update the metrics as a table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SataQiu [email protected]
Ⅰ. Describe what this PR did
docs: update the metrics as a table
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews