This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
bugfix: fix missing error message 'Unable to autodetect advertiser ip… #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found this is your first time to contribute to Dragonfly, @zhaxzhax |
…, please set it via --advertise-ip' related to dragonflyoss#1428 Signed-off-by: zhaxzhax <[email protected]>
lowzj
added a commit
to lowzj/Dragonfly
that referenced
this pull request
Jul 16, 2020
bugfix: fix missing error message 'Unable to autodetect advertiser ip
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, please set it via --advertise-ip'
related to #1428
Ⅰ. Describe what this PR did
This PR have fixed the missing error message bug in #1428.
Ⅱ. Does this pull request fix one issue?
Fixes #1428.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
There is already a root_test file, and the test need under the condition when the container only shows the loopback address.
Ⅳ. Describe how to verify it
Just return error when only can get the loopback address instead of writing debug information into the logs.
Ⅴ. Special notes for reviews
None.