Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

When only loopback is found, provide a clear error message. #1428

Closed
eatwithforks opened this issue Jul 13, 2020 · 1 comment · Fixed by #1429
Closed

When only loopback is found, provide a clear error message. #1428

eatwithforks opened this issue Jul 13, 2020 · 1 comment · Fixed by #1429
Labels
kind/bug This is bug report for project

Comments

@eatwithforks
Copy link

Why you need it?

on my node, the container shows only the loopback address

bash-4.4# ifconfig
lo        Link encap:Local Loopback
          inet addr:127.0.0.1  Mask:255.0.0.0
          inet6 addr: ::1/128 Scope:Host
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

so when i start up the supernode server, i get an error message:

Error: peer IP: : {"Code":2,"Msg":"invalid value"}

It would have saved a lot of debugging time if the error message said "Unable to autodetect advertiser ip, please set it via --advertise-ip
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Jul 13, 2020
@zhaxzhax
Copy link
Contributor

It's true that Drangonfly miss catching the situation "Unable to autodetect advertiser ip".
I'm gonna fix this.

zhaxzhax added a commit to zhaxzhax/Dragonfly that referenced this issue Jul 14, 2020
@zhaxzhax
bugfix: fix missing error message 'Unable to autodetect advertiser ip…
2a721fe 
…, please set it via --advertise-ip'

related to dragonflyoss#1428
@zhaxzhax zhaxzhax mentioned this issue Jul 14, 2020
Merged
zhaxzhax added a commit to zhaxzhax/Dragonfly that referenced this issue Jul 14, 2020
@zhaxzhax
bugfix: fix missing error message 'Unable to autodetect advertiser ip…
2ea9362 
…, please set it via --advertise-ip'

related to dragonflyoss#1428

Signed-off-by: zhaxzhax <[email protected]>
lowzj pushed a commit to lowzj/Dragonfly that referenced this issue Jul 16, 2020
@zhaxzhax @lowzj
bugfix: fix missing error message 'Unable to autodetect advertiser ip…
5eb5540 
…, please set it via --advertise-ip'

related to dragonflyoss#1428

Signed-off-by: zhaxzhax <[email protected]>
@weekly-digest weekly-digest bot mentioned this issue Jul 19, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug This is bug report for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: fix missing error message 'Unable to autodetect advertiser ip… zhaxzhax/Dragonfly
3 participants
@eatwithforks @pouchrobot @zhaxzhax