Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Firebase Crashlytics from Fabric Crashlytics #432

Closed
wants to merge 24 commits into from

Conversation

vickydlion
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [1] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • [1] Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Upgraded to Firebase crashlytics from fabric crashlytics.

Does this PR introduce a breaking change?

  • Yes
  • [1] No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

dpa99c and others added 24 commits April 16, 2020 18:51
…olution of fetchDocumentInFirestoreCollection().
…sent from native iOS implementation to JS console. Resolves dpa99c#401.
@dpa99c
Copy link
Owner

dpa99c commented Jun 16, 2020

Thanks for this @vickydlion, I'll give it a regression test ASAP

@dpa99c dpa99c changed the title Cli build Migrate to Firebase Crashlytics from Fabric Crashlytics Jun 16, 2020
@Roshankd1
Copy link

thank you for this @vickydlion

@giuale88
Copy link

@vickydlion great

@vickydlion
Copy link
Author

Cheers to Everyone 👍

@aranjan
Copy link

aranjan commented Jun 18, 2020

Nice one @vickydlion, thanks for your contribution.

@dpa99c dpa99c changed the base branch from cli_build to dev June 18, 2020 13:08
@dpa99c dpa99c force-pushed the dev branch 2 times, most recently from 690dfa6 to d6c60a2 Compare June 18, 2020 15:40
@dpa99c
Copy link
Owner

dpa99c commented Jun 18, 2020

I've made a commit based on this PR which is currently on the dev branch.

I've successfully tested on iOS but currently not seeing any crash data for Android using the new Firebase Crashlytics implementation.
If someone else could also give the dev branch and test and confirm if they see crashlytics data for Android, that'd be great.

To install the plugin direct from the dev branch:

cordova plugin add https://github.com/dpa99c/cordova-plugin-firebasex#dev

Will close this PR now as it's essentially merged - thanks again @vickydlion

@Roshankd1
Copy link

@dpa99c quick question, in case of Ionic app, could we continue using "@ionic-native/firebase-x": "^5.26.0"
Thank you again.

@Roshankd1
Copy link

@vickydlion Hey Vivek, I am not seeing crash reports for Android. Is it the same for you?

@stegithub
Copy link

I've made a commit based on this PR which is currently on the dev branch.

I've successfully tested on iOS but currently not seeing any crash data for Android using the new Firebase Crashlytics implementation.
If someone else could also give the dev branch and test and confirm if they see crashlytics data for Android, that'd be great.

To install the plugin direct from the dev branch:

cordova plugin add https://github.com/dpa99c/cordova-plugin-firebasex#dev

Will close this PR now as it's essentially merged - thanks again @vickydlion

Is it merged in production version? Or when will it be merged? Thanks for your work

@Roshankd1
Copy link

@dpa99c Hey Dave, any suggestions here, in iOS I am getting this error while trying out this merge.

`Firebase Installation registration failed for app with name: __FIRAPP_DEFAULT, error:
The server responded with an error:

  • URL: https://firebaseinstallations.googleapis.com/v1/projects/my-app-prod/installations/
  • HTTP status code: 403
  • Response body: {
    "error": {
    "code": 403,
    "message": "Requests to this API firebaseinstallations.googleapis.com method google.firebase.installations.v1.FirebaseInstallationsService.CreateInstallation are blocked.",
    "status": "PERMISSION_DENIED",
    "details": [
    {
    "@type": "type.googleapis.com/google.rpc.Help",
    "links": [
    {
    "description": "Google developer console API key",
    "url": "https://console.developers.google.com/project/561605196520/apiui/credential"
    }
    ]
    }
    ]
    }
    }
    `

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants