-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Firebase Crashlytics from Fabric Crashlytics #432
Conversation
…olution of fetchDocumentInFirestoreCollection().
# Conflicts: # README.md
…sent from native iOS implementation to JS console. Resolves dpa99c#401.
…efaults to false. Resolves dpa99c#406.
…pa99c#344. Also bump xcode dependency to latest v3.0.1
Thanks for this @vickydlion, I'll give it a regression test ASAP |
thank you for this @vickydlion |
@vickydlion great |
Cheers to Everyone 👍 |
Nice one @vickydlion, thanks for your contribution. |
690dfa6
to
d6c60a2
Compare
I've made a commit based on this PR which is currently on the dev branch. I've successfully tested on iOS but currently not seeing any crash data for Android using the new Firebase Crashlytics implementation. To install the plugin direct from the dev branch:
Will close this PR now as it's essentially merged - thanks again @vickydlion |
@dpa99c quick question, in case of Ionic app, could we continue using "@ionic-native/firebase-x": "^5.26.0" |
@vickydlion Hey Vivek, I am not seeing crash reports for Android. Is it the same for you? |
Is it merged in production version? Or when will it be merged? Thanks for your work |
@dpa99c Hey Dave, any suggestions here, in iOS I am getting this error while trying out this merge. `Firebase Installation registration failed for app with name: __FIRAPP_DEFAULT, error:
|
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
Upgraded to Firebase crashlytics from fabric crashlytics.
Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
What testing has been done on existing functionality?
Other information