Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signOutUser #353

Closed
xurdep opened this issue Mar 30, 2020 · 5 comments
Closed

signOutUser #353

xurdep opened this issue Mar 30, 2020 · 5 comments
Labels
bug Something isn't working properly runtime issue An issue related to app runtime

Comments

@xurdep
Copy link

xurdep commented Mar 30, 2020

Feature request

Is posible that method signOutUser removes all Google cache files? When you sign out and then sign in again, the account chooser doesn't show.. Next time you sign in, the login is silent with the previous account.
Account chooser only is showed at the first time you sign in. I don't know if this is a bug or is something that is not implemented yet.
Thank you in advange!

@dpa99c
Copy link
Owner

dpa99c commented Mar 31, 2020

This looks to be a bug - well, a shortcoming in Firebase's use of Google SignIn anyway...
I had assumed Firebase would take care of signing out of Google when you signed out of Firebase, but apparently not: it seems you must manually sign out of both on Android and iOS.

I will test this scenario and implement a fix in the next plugin release if needed.

@dpa99c dpa99c added bug Something isn't working properly investigate Issue requires investigation runtime issue An issue related to app runtime labels Mar 31, 2020
@xurdep
Copy link
Author

xurdep commented Mar 31, 2020 via email

@xurdep
Copy link
Author

xurdep commented Apr 4, 2020

How can I test this changes?? Can I overwrite the commited file srcc/android/FirebasePlugin.java and build again? Thank you

@dpa99c dpa99c closed this as completed in 9cd0c08 Apr 5, 2020
@dpa99c
Copy link
Owner

dpa99c commented Apr 5, 2020

You can install directly off the master branch until this is released in the next version to npm:

cordova plugin rm cordova-plugin-firebasex --nosave && cordova plugin add https://github.com/dpa99c/cordova-plugin-firebasex --nosave

@dpa99c dpa99c added ready for release Something has been implemented and is awaiting release to npm and removed investigate Issue requires investigation labels Apr 5, 2020
@xurdep
Copy link
Author

xurdep commented Apr 6, 2020

You can install directly off the master branch until this is released in the next version to npm:

cordova plugin rm cordova-plugin-firebasex --nosave && cordova plugin add https://github.com/dpa99c/cordova-plugin-firebasex --nosave

Hi!
It works like a charm!
But I had problems uninstalling the plugin and added with the above command, I think It was for version conflict with other plugins but I'm not sure and I didn't want "another plugin war" jajaja...

Finally I solved adding changes manually to FirebasePlugin.java file existing in "plugins" and "node_modules" folders and rebuild until new version is released.

Thank you @dpa99c
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly runtime issue An issue related to app runtime
Projects
None yet
Development

No branches or pull requests

2 participants