fix: add clean up to avoid effect firing twice in strict mode

[jeanpan]

What:

Add clean up function to isInitialMountRef initialization.

Why:

It fixes the bug that when the page load and if the dropdown is not above the content, the dropdown is focused and cases the page scrolled in strict mode.

How:

As react official doc, we should add clean-up function for initialization on effect to avoid the effect firing twice in the strict mode (development mode)

Checklist:

• Documentation
• Tests
• TypeScript Types
• Flow Types
• Ready to be merged
  

[silviuaavram]

Hi @jeanpan! Thanks for the fix!

Can you run prettier over the code? The build fails because of too many statements, and it can be easily be fixed by prettier since it already has the rule from kcd-scipts.

[jeanpan]

@silviuaavram, sorry for the late reply. Updated to fix the lint error. Could you review this again?

[codecov-commenter]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (04d0b85) compared to base (04a9d9d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1684      1690    +6     
  Branches       503       503           
=========================================
+ Hits          1684      1690    +6     

Impacted Files	Coverage Δ
src/hooks/useCombobox/index.js	100.00% <100.00%> (ø)
src/hooks/useMultipleSelection/index.js	100.00% <100.00%> (ø)
src/hooks/useSelect/index.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[silviuaavram]

@all-contributors please add @jeanpan for code

[allcontributors]

@silviuaavram

I've put up a pull request to add @jeanpan! 🎉

[github-actions]

🎉 This PR is included in version 7.0.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀