fix: add clean up to avoid effect firing twice in strict mode (#1436)

Co-authored-by: jeanpan <[email protected]>
downshift-js · Dec 17, 2022 · 25a673b · 25a673b
1 parent 795a8d1
commit 25a673b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/hooks/useCombobox/index.js b/src/hooks/useCombobox/index.js
@@ -139,6 +139,10 @@ function useCombobox(userProps = {}) {
   // Make initial ref false.
   useEffect(() => {
     isInitialMountRef.current = false
+
+    return () => {
+      isInitialMountRef.current = true
+    }
   }, [])
   // Reset itemRefs on close.
   useEffect(() => {

diff --git a/src/hooks/useMultipleSelection/index.js b/src/hooks/useMultipleSelection/index.js
@@ -99,6 +99,10 @@ function useMultipleSelection(userProps = {}) {
   // Make initial ref false.
   useEffect(() => {
     isInitialMountRef.current = false
+
+    return () => {
+      isInitialMountRef.current = true
+    }
   }, [])
 
   // Event handler functions.

diff --git a/src/hooks/useSelect/index.js b/src/hooks/useSelect/index.js
@@ -159,6 +159,10 @@ function useSelect(userProps = {}) {
   // Make initial ref false.
   useEffect(() => {
     isInitialMountRef.current = false
+
+    return () => {
+      isInitialMountRef.current = true
+    }
   }, [])
   // Reset itemRefs on close.
   useEffect(() => {