Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #183 #187

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Fix for #183 #187

merged 1 commit into from
Dec 7, 2019

Conversation

doug-martin
Copy link
Owner

  • Changed AppendSQL to set error if one is present

delete_dataset.go Outdated Show resolved Hide resolved
update_dataset.go Outdated Show resolved Hide resolved
issues_test.go Outdated Show resolved Hide resolved
* Changed AppendSQL to set error if one is present
@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v9.5.1-rc@20ea999). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             v9.5.1-rc     #187   +/-   ##
============================================
  Coverage             ?   96.25%           
============================================
  Files                ?       56           
  Lines                ?     4003           
  Branches             ?        0           
============================================
  Hits                 ?     3853           
  Misses               ?      135           
  Partials             ?       15
Impacted Files Coverage Δ
insert_dataset.go 100% <100%> (ø)
delete_dataset.go 100% <100%> (ø)
select_dataset.go 100% <100%> (ø)
update_dataset.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ea999...3b783f9. Read the comment docs.

@doug-martin doug-martin merged commit 1b15b2a into v9.5.1-rc Dec 7, 2019
@doug-martin doug-martin added this to the v9.5.1 milestone Dec 7, 2019
@doug-martin doug-martin deleted the issue183 branch October 16, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants