You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If you use SelectDataset From and pass it another SelectDataset that has an error already set on it, it seems to ignore the error on the subselect instead of propagating it.
If you run this test the first assertion passes, but the second assertion fails.
Error: Expected value not to be nil.
Test: TestSelectWithSubSelectError
Expected behavior
I would expect using a SelectDataset as a subselect on another SelectDataset would honor the error and propagate it rather than swallow the error. Obviously the caller can check this scenario with gs.Error() before using it in a subselect, but I think that puts too much burden on the caller IMO and this is something goqu should handle.
Dialect:
postgres
mysql
sqlite3
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Describe the bug
If you use
SelectDataset
From and pass it anotherSelectDataset
that has an error already set on it, it seems to ignore the error on the subselect instead of propagating it.To Reproduce
If you run this test the first assertion passes, but the second assertion fails.
Expected behavior
I would expect using a SelectDataset as a subselect on another SelectDataset would honor the error and propagate it rather than swallow the error. Obviously the caller can check this scenario with
gs.Error()
before using it in a subselect, but I think that puts too much burden on the caller IMO and this is something goqu should handle.Dialect:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: