Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Switch between threadless and multi-threaded runner #1145

Merged
merged 5 commits into from
Jan 27, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 26, 2024

  • Switch between threadless and multi-threaded XUnit runner for WASM based on IsThreadless property
  • The property will be set in the runtime based on passed flags and based on used runtime flavor
  • Mutli-threaded runner extends the runner for other platforms and overrides how results are written (as single line)
  • Add current thread id to STRT, PASS and FAIL messages when enabled with XHARNESS_LOG_THREAD_ID

Contributes to dotnet/runtime#88763

@maraf maraf added the wasm WASM area label Jan 26, 2024
@maraf maraf self-assigned this Jan 26, 2024
@maraf maraf changed the title [browser] Switch between threadless and multi-threaded runner [wasm] Switch between threadless and multi-threaded runner Jan 26, 2024
@pavelsavara
Copy link
Member

Note that the thread ID could be misleading. The task could start on different thread than all the continuations etc ...

@maraf
Copy link
Member Author

maraf commented Jan 26, 2024

Note that the thread ID could be misleading. The task could start on different thread than all the continuations etc ...

I do undestand. When we talked about it few months, you agreed it could be usefull sometimes. I can revert it if you don't se any value in it now

@pavelsavara
Copy link
Member

Note that the thread ID could be misleading. The task could start on different thread than all the continuations etc ...

I do undestand. When we talked about it few months, you agreed it could be usefull in sometimes. I can revert it if you don't any value in it now

I learned more since. I don't mind having it behind a flag and occasionally try if it helps to resolve something.

@maraf maraf merged commit f49b5c0 into dotnet:main Jan 27, 2024
17 checks passed
@maraf maraf deleted the WasmRunnerThreads branch January 27, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasm WASM area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants