Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][mt] Stop using ThreadlessXunitTestRunner for MT unit tests #88763

Closed
pavelsavara opened this issue Jul 12, 2023 · 3 comments · Fixed by #91317
Closed

[browser][mt] Stop using ThreadlessXunitTestRunner for MT unit tests #88763

pavelsavara opened this issue Jul 12, 2023 · 3 comments · Fixed by #91317
Assignees
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Milestone

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Jul 12, 2023

On wasm/browser we use Xharness and it's ThreadlessXunitTestRunner because until now, we didn't have way how to run multiple threads and how to synchronously Task.Wait.

To make sure that our MT tests are closer to normal MT execution, we should try to stop using ThreadlessXunitTestRunner and see what happens when we use the same as other OSes.

  • The non-MT build should still be using it. So this needs to be new xharness parameter.
  • WasmTestRunner is part of the machinery
  • We still need to proxy console from the browser.
  • It may mean that we will run tests in parallel on threads.
  • It will uncover new issues, which we need to mark ActiveIssue
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm labels Jul 12, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 12, 2023
@pavelsavara pavelsavara self-assigned this Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-Infrastructure-mono, os-browser

Milestone: 8.0.0

@pavelsavara pavelsavara removed their assignment Jul 13, 2023
@pavelsavara
Copy link
Member Author

pavelsavara commented Jul 13, 2023

To make local experiments easier, you can build Xharness locally and then
set XHARNESS_CLI_PATH=c:\Dev\xharness\artifacts\bin\Microsoft.DotNet.XHarness.CLI\Release\net6.0\Microsoft.DotNet.XHarness.CLI.dll

runtime tests will start using your local build.

@pavelsavara
Copy link
Member Author

@maraf you made some progress on something related ?

@maraf maraf self-assigned this Jan 26, 2024
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 29, 2024
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants