Remove NetCoreReference #9914
Open
Remove NetCoreReference #9914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `NetCoreReference` infrastructure and replaces it with `DefaultReferenceExclusion` to remove the one problematic implicit reference to WindowsBase. Manually picking references was blocking using System.Private.Windows.Core from the WinForms repo. Not having this also greatly simplifies the projects. This also tweaks the solution to add folders docs and eng items. Fixes dotnet#9168
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
src/Microsoft.DotNet.Wpf/src/PresentationUI/PresentationUI.csproj
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Oct 9, 2024
| </_referenceExclusion> | ||
|
|
||
| <Reference Remove="@(_referenceExclusion)" | ||
| MatchOnMetadata="AssemblyName;FrameworkReferenceName;ExternallyResolved"/> |
There was a problem hiding this comment.
Did you need all of this - I guess you did this so you wouldn't need to intersect DefaultReferenceExclusion with Reference
There was a problem hiding this comment.
I tried a number of different ways, and this seemed to be the cleanest and easiest to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
NetCoreReferenceinfrastructure and replaces it withDefaultReferenceExclusionto remove the one problematic implicit reference to WindowsBase.Manually picking references was blocking using System.Private.Windows.Core from the WinForms repo. Not having this also greatly simplifies the projects.
This also tweaks the solution to add folders docs and eng items.
Fixes #9168
Microsoft Reviewers: Open in CodeFlow