Update SplashScreen to use CsWin32 and shared library #10047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
JeremyKuhne
force-pushed
the
newsplash
branch
2 times, most recently
from
877f249
to
f1987f5
Compare
lonitra
reviewed
Nov 11, 2024
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
|
Changes LGTM! |
|
Good job. And I want to bring the some more feature to SplashScreen. See #2031 |
|
@lindexi it should be significantly faster now that it doesn't have to generate all of the interop at start |
h3xds1nz
reviewed
Nov 14, 2024
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/SplashScreen.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/Resources.Designer.cs
Outdated
Show resolved
Hide resolved
Kuldeep-MS
previously approved these changes
Nov 14, 2024
…t also uses the shared `System.Private.Windows.Core` library built in Windows Forms. This makes `SplashScreen` trim-friendly and improves the performance as it will no longer need to generate the rather extensive interop it used to at startup. This also introduces a bottom level assembly for WPF: `System.Windows.Primitives` where there are no other dependencies other than the WinForms/WPF base assembly: `System.Private.Windows.Core`. `PInvokeCore` is the static class that comes from `System.Private.Windows.Core`. `PInvoke` is the static class from `System.Windows.Primitives`. When C# adds something akin to extension types (currently in the design phase) we'll be able to unify to a single `PInvoke`. Generated types (such as `HWND`) are in the namespaces as specified by the Windows metdata and don't have the same problem with conflicts as CsWin32 won't generate types that already exist. CsWin32 uses `System.Drawing` types where they match Win32 types. `Point` is an example of this. These interchange `System.Drawing` types are in-box with .NET. `System.Private.Windows.Core` provides a lot of useful support functionality, particularly when it comes to interop. The various scope types in this PR are an example. OLE code will come from this assembly after the new APIs are merged in WinForms. I've also deleted a large swath of unused interop. It builds on dotnet#10023, which leverages dotnet#9914. This is an update of dotnet#7929.
JeremyKuhne
force-pushed
the
newsplash
branch
from
3490d2d
to
79ae146
Compare
|
LGTM, really happy to see this. ❤️ |
|
Did another pass, changes look good 👍 |
Kuldeep-MS
approved these changes
Nov 15, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
SplashScreento use direct interop built on CsWin32. It also uses the sharedSystem.Private.Windows.Corelibrary built in Windows Forms.This makes
SplashScreentrim-friendly and improves the performance as it will no longer need to generate the rather extensive interop it used to at startup.This also introduces a bottom level assembly for WPF:
System.Windows.Primitiveswhere there are no other dependencies other than the WinForms/WPF base assembly:System.Private.Windows.Core.PInvokeCoreis the static class that comes fromSystem.Private.Windows.Core.PInvokeis the static class fromSystem.Windows.Primitives. When C# adds something akin to extension types (currently in the design phase) we'll be able to unify to a singlePInvoke. Generated types (such asHWND) are in the namespaces as specified by the Windows metdata and don't have the same problem with conflicts as CsWin32 won't generate types that already exist.CsWin32 uses
System.Drawingtypes where they match Win32 types.Pointis an example of this. These interchangeSystem.Drawingtypes are in-box with .NET.System.Private.Windows.Coreprovides a lot of useful support functionality, particularly when it comes to interop. The various scope types in this PR are an example. OLE code will come from this assembly after the new APIs are merged in WinForms.I've also deleted a large swath of unused interop.
It leverages #10023, which leverages #9914 (the first commit), and will be updated when those are merged.
This is an update of #7929.
Microsoft Reviewers: Open in CodeFlow