Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/3.1] Update dependencies from dotnet/arcade #3272

Closed
wants to merge 1 commit into from
Closed

[release/3.1] Update dependencies from dotnet/arcade #3272

wants to merge 1 commit into from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: f6560d32-4c6b-4ed3-5c71-08d72a4d3f20
  • Build: 20200715.6
  • Date Produced: 7/16/2020 1:27 AM
  • Commit: 7cc59275eade471e29b88a797275818b0d513d0f
  • Branch: refs/heads/release/3.x
  • Updates:
    • Microsoft.DotNet.ApiCompat: from 1.0.0-beta.20113.5 to 1.0.0-beta.20365.6
    • Microsoft.DotNet.Arcade.Sdk: from 1.0.0-beta.20113.5 to 1.0.0-beta.20365.6
    • Microsoft.DotNet.CodeAnalysis: from 1.0.0-beta.20113.5 to 1.0.0-beta.20365.6
    • Microsoft.DotNet.GenAPI: from 1.0.0-beta.20113.5 to 1.0.0-beta.20365.6
    • Microsoft.DotNet.Helix.Sdk: from 2.0.0-beta.20113.5 to 2.0.0-beta.20365.6

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
1ca1c5c 
…715.6

Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 1.0.0-beta.20113.5 -> To Version 1.0.0-beta.20365.6
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 20, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent July 20, 2020 17:10
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 20, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@wtgodbe
Copy link
Member

wtgodbe commented Jul 20, 2020

F:\workspace_work\1\s\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\InstallationError.g.cs(40,18): error CS1504: Source file 'InstallationError.xaml' could not be opened -- Could not find file. [F:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\PresentationUI\PresentationUI_2uwlcykt_wpftmp.csproj]

@ryalanms do you know who could take a look at this? We need to take this arcade update to unblock SDL validation in 3.1. It's somewhat urgent as this is blocking the build for 3.1.7

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 20, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ryalanms
Copy link
Member

After this change, PresentationUI fails to build:

artifacts\obj\PresentationUI\Debug\netcoreapp3.1\InstallationError.g.cs#L40
artifacts\obj\PresentationUI\Debug\netcoreapp3.1\InstallationError.g.cs(40,18): error CS1504: Source file 'InstallationError.xaml' could not be opened -- Could not find file.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 20, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ryalanms
Copy link
Member

These 'embed' parameters were not passed to csc before the update:

/embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\InstallationError.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\TenFeetInstallationError.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\TenFeetInstallationProgress.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\MS\Internal\Documents\FindToolbar.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\MS.Internal.Documents.Resources.cs /embed:"D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1.NETCoreApp,Version=v3.1.AssemblyAttributes.cs" /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\System.Windows.TrustUI.SRID.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\PresentationUI_rdq3st4q_wpftmp.AssemblyInfo.c

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 20, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

This was referenced Jul 20, 2020
Merged
Merged
@wtgodbe wtgodbe closed this Aug 11, 2020
@wtgodbe wtgodbe deleted the darc-release/3.1-62ca362b-55c1-4e96-9d7c-a9c1abc01093 branch August 11, 2020 17:19
@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @ryalanms