Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set EmbedUntrackedSources to true by default (#4063) #5278

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 16, 2020

Description

Port #4063 to 3.x

Customer Impact

Enables embedding generated source files to PDB by default. Required for Source Link validation.

Regression

No

Risk

Small.

Workarounds

None.

Copy link
Contributor

@JohnTortugo JohnTortugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU chances of this breaking someone is very very low. Right?!

@tmat
Copy link
Member Author

tmat commented Apr 16, 2020

Yes, break seems unlikely. If it does that would be a product bug and we would definitely want to know about that.

@tmat tmat merged commit bebaa0c into dotnet:release/3.x Apr 17, 2020
@tmat tmat deleted the Embed3x branch April 17, 2020 22:50
@wtgodbe
Copy link
Member

wtgodbe commented Jul 20, 2020

@tmat we think this caused a break in WPF: dotnet/wpf#3272

After this change, PresentationUI fails to build:

artifacts\obj\PresentationUI\Debug\netcoreapp3.1\InstallationError.g.cs#L40
artifacts\obj\PresentationUI\Debug\netcoreapp3.1\InstallationError.g.cs(40,18): error CS1504: Source file 'InstallationError.xaml' could not be opened -- Could not find file.

These 'embed' parameters were not passed to csc before the update:

/embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\InstallationError.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\TenFeetInstallationError.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\TenFeetInstallationProgress.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\MS\Internal\Documents\FindToolbar.g.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\MS.Internal.Documents.Resources.cs /embed:"D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1.NETCoreApp,Version=v3.1.AssemblyAttributes.cs" /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\System.Windows.TrustUI.SRID.cs /embed:D:\wpf2\artifacts\obj\PresentationUI\Debug\netcoreapp3.1\PresentationUI_rdq3st4q_wpftmp.AssemblyInfo.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants