Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using run-in-terminal for 'dotnet restore' #238

Merged

Conversation

DustinCampbell
Copy link
Member

Stop opening a new terminal window to run 'dotnet restore'. Instead, launch 'dotnet restore' as a child process and capture the output

cc @gregg-miskelly, @chuckries, @caslan, @Pilchie

@DustinCampbell DustinCampbell self-assigned this Apr 22, 2016
@DustinCampbell DustinCampbell added this to the 1.0.0-rtm milestone Apr 22, 2016

return vscode.window.showQuickPick(commands).then(command => {
return Promise.all(commandPromises).then(commands => {
return vscode.window.showQuickPick(commands);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't change this but curious - why does it ask which project to restore instead of restoring all of them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same thing. I think we should probably add a separate command that uses the picker. Also, if there's just a single project, it should populate the picker. It should just execute the dotnet restore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File #240 to track a better experience here.

@gregg-miskelly
Copy link
Contributor

👍

@Pilchie
Copy link
Member

Pilchie commented Apr 22, 2016

👍 Having the extra terminal window pop up has been bugging me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants