Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code - Info: Resolve Dependancies Fails if User Path contains a SPACE #2

Closed
jrieken opened this issue Jan 20, 2016 · 2 comments
Closed

VS Code - Info: Resolve Dependancies Fails if User Path contains a SPACE #2

jrieken opened this issue Jan 20, 2016 · 2 comments
Labels
Bug Resolved-Fixed

Comments

@jrieken
Copy link
Contributor

jrieken commented Jan 20, 2016

From @sporens on January 17, 2016 20:57

Hi,

The command executed by VS Code to install and resolve missing dependancies for an ASP.NET application fails with "Can't find path" when the path to the users' home folder includes a space. For example:
c:\users\joeblogs\ <- works
c:\users\joe blogs\ <- fails

Running procmon I see it's attempting to execute:
cmd.exe /c start /wait cmd.exe /c "C:\Users\joe blogs.dnx\runtimes\dnx-clr-win-x86.1.0.0-rc1-update1\bin\dnu.cmd restore & pause"

Which fails.

Thanks

Copied from original issue: microsoft/vscode#2072
@jrieken jrieken self-assigned this Jan 20, 2016
@jrieken jrieken added the c# label Jan 20, 2016
@jrieken
Copy link
Contributor Author

jrieken commented Jan 20, 2016

this is either omnisharp-vscode or omnisharp itself

This was referenced Jan 20, 2016
Closed
Closed
@jrieken jrieken removed their assignment Jan 20, 2016
@DustinCampbell DustinCampbell added Bug and removed c# labels Jan 25, 2016
DustinCampbell added a commit that referenced this issue Feb 18, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
fc908a1 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Feb 18, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
c3f9680 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Feb 26, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
8bc3115 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Feb 26, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
796fe87 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Mar 1, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
2cb99ae 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit to DustinCampbell/vscode-csharp that referenced this issue Mar 2, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
f9fccd4 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, dotnet#2 and dotnet#3 would be ignored even if the value of #1 was invalid. Likewise, if dotnet#2 was set, dotnet#3 would be ignored even if the value of dotnet#2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit to DustinCampbell/vscode-csharp that referenced this issue Mar 4, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
cbd3780 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, dotnet#2 and dotnet#3 would be ignored even if the value of #1 was invalid. Likewise, if dotnet#2 was set, dotnet#3 would be ignored even if the value of dotnet#2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Mar 4, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
8cfdabf 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
@germansak germansak mentioned this issue Apr 15, 2016
Closed
@DustinCampbell
Copy link
Member

Fixed for 'dotnet' with PR #238

@fregren fregren mentioned this issue Aug 27, 2016
Closed
@nozer nozer mentioned this issue Apr 23, 2017
Closed
@qian6 qian6 mentioned this issue Jul 3, 2017
Closed
@qian6 qian6 mentioned this issue Oct 24, 2017
Closed
TheRealPiotrP referenced this issue in TheRealPiotrP/omnisharp-vscode Mar 6, 2018
@akshita31
Merge pull request #2 from TheRealPiotrP/dev/piotrp/refactorLogging
eb8085a 
Refactor telemetry
@ClaireKang ClaireKang mentioned this issue Aug 31, 2018
Closed
@4verage 4verage mentioned this issue Sep 27, 2018
Closed
Samirat added a commit to github/omnisharp-vscode that referenced this issue May 21, 2020
@Samirat
Merge pull request dotnet#2 from Samirat/users/jobrooks/add_test_comp…
6e6b210 
…leted_event

Add test completed events when running multiple tests in a single requests
@Mailaender Mailaender mentioned this issue Mar 26, 2021
Closed
JoeRobich added a commit that referenced this issue May 18, 2021
@JoeRobich
Merge pull request #2 from 333fred/update-tests
2c22a0b
@gregg-miskelly gregg-miskelly mentioned this issue Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Resolved-Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DustinCampbell @jrieken