Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETSDK1206 warns on platforms that should be vaild when project has no FrameworkReference #34003

Closed
elinor-fung opened this issue Jul 13, 2023 · 0 comments · Fixed by #34021
Closed

NETSDK1206 warns on platforms that should be vaild when project has no FrameworkReference #34003

elinor-fung opened this issue Jul 13, 2023 · 0 comments · Fixed by #34021
Assignees
@elinor-fung
Labels
Area-NetSDK untriaged Request triage from a team member

Comments

@elinor-fung
Copy link
Member

elinor-fung commented Jul 13, 2023 •
edited
Loading

Describe the bug

NETSDK1206 warning is firing when project has no FrameworkReferences. The warning uses determines valid/portable platforms based on processing FrameworkReference.

This can happen when DisableImplicitFrameworkReferencs is set and no framework references are added. This is likely not much of a problem for normal builds, but it is for building the runtime framework libraries themselves. We should probably not warn if there are no framework references.

To Reproduce

See dotnet/runtime#88827 - build of System.Net.Quic for windows or osx
@elinor-fung elinor-fung self-assigned this Jul 13, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Jul 13, 2023
@elinor-fung elinor-fung mentioned this issue Jul 13, 2023
Open
elinor-fung added a commit to dotnet/runtime that referenced this issue Jul 14, 2023
@elinor-fung
Workaround for dotnet/sdk#34003
e426ecf
@elinor-fung elinor-fung mentioned this issue Jul 14, 2023
Merged
lewing pushed a commit to dotnet/runtime that referenced this issue Jul 14, 2023
@dotnet-maestro @ViktorHofer @elinor-fung
[main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/…
b40d643 
…emsdk (#88827)

* Update dependencies from https://github.com/dotnet/arcade build 20230712.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23362.5

Dependency coherency updates

Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
 From Version 8.0.0-beta.23360.2 -> To Version 8.0.0-beta.23361.2 (parent: Microsoft.DotNet.Arcade.Sdk

* Update dependencies from https://github.com/dotnet/emsdk build 20230712.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.7.23361.2 -> To Version 8.0.0-preview.7.23362.1

* Update Tools.props

* Update Version.Details.xml

* Suppress warning in test

* Workaround for dotnet/sdk#34003

* Update dependencies from https://github.com/dotnet/xharness build 20230713.3

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 8.0.0-prerelease.23360.3 -> To Version 8.0.0-prerelease.23363.3

* Add reference to NETStandard.Library

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <[email protected]>
Co-authored-by: Elinor Fung <[email protected]>
@elinor-fung elinor-fung mentioned this issue Aug 10, 2023
Closed
bricelam added a commit to dotnet/efcore that referenced this issue Aug 23, 2023
@bricelam
Remove dotnet/sdk#34003 workaround
cf9391b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elinor-fung elinor-fung

Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't fire NETSDK1206 if known RID platforms were not determined elinor-fung/sdk
1 participant
@elinor-fung