[main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/emsdk #88827
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…712.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23362.5 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23360.2 -> To Version 8.0.0-beta.23361.2 (parent: Microsoft.DotNet.Arcade.Sdk
…12.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.7.23361.2 -> To Version 8.0.0-preview.7.23362.1
dotnet-maestro
bot
changed the title
|
@ViktorHofer are the sourcelink errors related to your revert? |
|
Yes, will take a look. |
|
And now it appears the sdk bump is the issue |
|
@elinor-fung this looks like dotnet/sdk#33486 as we take the new sdk into runtime |
|
Couple of different things hitting NETSDK1206:
Still looking at System.Net.Quic - will need to update the SDK to handle this case and add a workaround in this repo. |
|
cc @ericstj regarding our custom RID builds in libraries |
…30713.3 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23360.3 -> To Version 8.0.0-prerelease.23363.3
dotnet-maestro
bot
changed the title
dotnet-maestro
bot
changed the title
| They won't actually get used at run time - package conflict resolution would normally handle removing them. However, | ||
| due to the way the repo builds, the platform manifest for the ref package has not yet been generated when this test | ||
| is being built, so they are not removed (and the SDK warns on it). --> | ||
| <NoWarn>$(NoWarn);NETSDK1206</NoWarn> |
There was a problem hiding this comment.
Can we just reference a later NETStandard.Library to avoid those dependencies? The latest NETStandard.Library package won't bring in the old PackageReferences.
There was a problem hiding this comment.
Yes, please add a PackageRefernce to NetStandard.Library with PrivateAssets="all"
There was a problem hiding this comment.
Can you check 2adf3d9 is what you mean?
I'm not entirely sure what you want me to look at, gave my best guess based on the state of this PR. Looks like remaining blockers are test failures. |
|
The TimeZone test failures here seem to be caused by #88641 cc @RenderMichael @tarekgh |
This has been fixed by @akoeplinger through the PR #88909. |
ghost
locked as resolved and limited conversation to collaborators
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/arcade
From https://github.com/dotnet/emsdk
From https://github.com/dotnet/xharness