Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] [mono][debugger] Send assembly_load events while invoking methods using debugger-libs #98254

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 10, 2024

Backport of #98253 to release/8.0-staging

/cc @thaystg

Customer Impact

  • Customer reported
  • Found internally

While .NET 9 was being tested internally, they reported that XAML HotReload was broken for MAUI. I fixed it on .NET 9 but the same problem was backported to .NET 8 for this release 8.0.300, so the fix should be merged.

Regression

  • Yes
  • No
    It would be a regression if we didn't fix it before 8.0.300 deadline.

Testing

Manually tested.

Risk

Low risk, using the old behavior for debugger-libs and the new behavior only for iCorDebug.

@ghost
Copy link

ghost commented Feb 10, 2024

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #98253 to release/8.0-staging

/cc @thaystg

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@danmoseley danmoseley added the Servicing-approved Approved for servicing release label Feb 12, 2024
@danmoseley danmoseley added this to the 8.0.3 milestone Feb 12, 2024
@thaystg thaystg merged commit ba68cf1 into release/8.0-staging Feb 12, 2024
103 of 110 checks passed
@jkotas jkotas deleted the backport/pr-98253-to-release/8.0-staging branch February 21, 2024 00:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants