[mono][debugger] Send assembly_load events while invoking methods using debugger-libs #98253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @thaystg Issue DetailsFix side effect of don't sending assembly_load while invoking methods. This changes make the HotReload XAML stop working because they use debugger-libs to invoke method Assembly.Load on runtime and wait to receive assembly load event for this assembly Xamarin.HotReload.Agent. This change is only allowed when debugging using iCorDebug.
|
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7851728242 |
4 tasks
tommcdon
approved these changes
Feb 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix side effect of don't sending assembly_load while invoking methods.
This changes make the HotReload XAML stop working because they use debugger-libs to invoke method Assembly.Load on runtime and wait to receive assembly load event for this assembly Xamarin.HotReload.Agent. This change is only allowed when debugging using iCorDebug.
#Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1951670