-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasi] Add build support for using wasm-opt
#95900
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis adds the build support but does not enable it by default which can be enabled with
|
Update: |
For browser this is `emcc-props.json` renamed. And for wasi, it's a new file.
64f96f0
to
99a5c04
Compare
TODO:
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
@@ -370,9 +370,7 @@ | |||
<Error Condition="'$(_WasiOutputFileName)' == ''" Text="Could not determine $(_WasiOutputFileName)" /> | |||
</Target> | |||
|
|||
<Target Name="_CheckToolchainIsExpectedVersion"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to implement this in a future PR.
This adds the build support but does not enable it by default which can be enabled with
$(WasmRunWasmOpt)=true
.Also, a new
wasm-props.json
file is added to thewasi
runtime pack. Forbrowser
this isemcc-props.json
with a new name.For browser this is
emcc-props.json
renamed. And for wasi, it's a newfile.