Add ILStrip+wasm_opt pass when using WasmSingleFileBundle

[lewing]

When using WasmSingleFileBundle+AOT we should be able to run ILStrip + wasm-opt which we think would optimize out the zero'd out memory. We should test this hypothesis on browser-wasm and implement it on wasi-wasm if it is true

cc @fanyang-mono @SamMonoRT

[ghost]

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	lewing
Assignees:	-
Labels:	area-Single-File
Milestone:	-

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	lewing
Assignees:	-
Labels:	arch-wasm, untriaged
Milestone:	-

[radical]

For browser-wasm the SingleFileBundle support is missing - #95480 .

[lewing]

We can run ilstrip by hand to test first but we should add it to the build anyway

[fanyang-mono]

I am not sure how to do WasmSingleFileBundle @radical Could you show me?

[radical]

This is covered by some other changes that I'm working on.

[fanyang-mono]

@radical If you are hitting any issues using it, feel free to let me know.

[lewing]

@radical what is the state of this, ILStrip is in, what is the state of wasm-opt?

[radical]

@radical what is the state of this, ILStrip is in, what is the state of wasm-opt?

It's not a separate step. I can extract that into one though.

runtime/src/mono/wasm/build/WasmApp.targets

Lines 507 to 511 in f83838b

	<Exec Command="wasm-opt$(_ExeExt) --enable-simd --enable-exception-handling @(WasmOptConfigurationFlags, ' ') --strip-dwarf &quot;$(_WasmIntermediateOutputPath)dotnet.native.wasm&quot; -o &quot;$(_WasmIntermediateOutputPath)dotnet.native.wasm&quot;"
	Condition="'$(WasmNativeStrip)' == 'true'"
	IgnoreStandardErrorWarningFormat="true"
	EnvironmentVariables="@(EmscriptenEnvVars)" />

What arguments do we want to run that with?

[lewing]

The discussion in https://github.com/dotnet/runtime/issues/94804 is relevant here. And https://github.com/emscripten-core/emscripten/blob/c54ebd73e383742e1e94729d863f97f23cfa8ff0/tools/link.py#L369 and if the section is indeed missing in the wasi build I assume clang is doing something similar in the final link step

[radical]

WIP - #95900

[radical]

The build has support for this now, but not all of it is working for example - browser-wasm+singlefilebundle .

[pavelsavara]

Note that because we now produce WASI components, wasm-opt can't be used on those until WebAssembly/binaryen#6728

But I think we il-strip on publish ?