Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Not IsWindows condition to IsLinux on Socket test disable #94163

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

liveans
Copy link
Member

@liveans liveans commented Oct 30, 2023

Addressing this comment

@liveans liveans requested a review from a team October 30, 2023 10:05
@liveans liveans self-assigned this Oct 30, 2023
@ghost
Copy link

ghost commented Oct 30, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Addressing this comment

Author: liveans
Assignees: liveans
Labels:

area-System.Net.Sockets

Milestone: -

@MihaZupan
Copy link
Member

Can you please match this condition on the EventSource_SocketConnectFailure_LogsConnectFailed test as well (assuming it's the same underlying issue)?

@liveans
Copy link
Member Author

liveans commented Oct 30, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Oct 30, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Oct 31, 2023

Outerloop failure is unrelated.

@liveans liveans merged commit f2e4ddf into dotnet:main Oct 31, 2023
171 of 174 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants