Disabling two socket tests #93916
Disabling two socket tests #93916
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsDisables #93737 and #93735 until the regression has been fixed. /cc @tmds @wfurt @antonfirsov
|
|
/azp list |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Looks like these tests are only failing for sync variants.
If we don't think we'll get them reenabled quickly, it may be worth scoping the condition to just those scenarios to avoid losing too much coverage. E.g.
if (UsesSync && !PlatformDetection.IsWindows)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/93737", TestPlatforms.Linux)]
return;
}
|
Is it worth merging the 2 bugs and keep just one to track the Linux kernel regression? |
|
@tmds is there any tracking issue for the regression that happened recently on the Linux kernel? |
There are a few issues for failing tests due to the regression. No specific issue is used to track the regression afaik. |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -137,6 +137,12 @@ public async Task Connect_AfterDisconnect_Fails() | |||
| [InlineData("[::ffff:1.1.1.1]", true, false)] | |||
| public async Task ConnectGetsCanceledByDispose(string addressString, bool useDns, bool owning) | |||
| { | |||
| if (UsesSync && !PlatformDetection.IsWindows) | |||
There was a problem hiding this comment.
Is there need to disable this also on macOS? It feels like !IsWindows should really be IsLinux????
Also this is regression in particular Linux Kernels. At that seems rare at this moment. It may be worth of adding version check instead of blindly disabling Linux runs -> it should still work on most supported distributions AFAIK.
There was a problem hiding this comment.
Ah yes, I've missed it. It should work as expected on macOS, thanks for catching that. I'll change it with another PR.
For the version controlling, AFAIK, only the latest kernel versions have this problem. Is there any example of version checking on Linux in .NET?
There was a problem hiding this comment.
It may be worth of adding version check instead of blindly disabling Linux runs
The change is being backported to some kernels, since it's considered to be security sensitive. I think it would be very difficult if not impossible to determine only by kernel version if a system is impacted.
* Disable two socket tests * Revert close to dispose * Disable tests against one issue
ghost
locked as resolved and limited conversation to collaborators
Disables #93737 and #93735 until regression in Linux kernel has been fixed.
Tracking issue: #94149
/cc @tmds @wfurt @antonfirsov