Add XUnitLogChecker to log libraries dumps #93906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
NO-MERGE
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
ericstj
reviewed
Oct 24, 2023
ericstj
reviewed
Oct 24, 2023
carlossanlop
changed the title
carlossanlop
commented
Oct 25, 2023
|
The XUnitLogChecker enhancements work is going to be tracked here in issue #93988. |
carlossanlop
commented
Oct 26, 2023
ericstj
reviewed
Oct 27, 2023
carlossanlop
force-pushed
the
LibrariesXUnitLogChecker
branch
from
cb64517
to
aa9e55f
Compare
This was referenced Oct 28, 2023
carlossanlop
force-pushed
the
LibrariesXUnitLogChecker
branch
from
ae25730
to
7f0fa13
Compare
ericstj
reviewed
Oct 31, 2023
ericstj
reviewed
Nov 1, 2023
carlossanlop
commented
Nov 2, 2023
carlossanlop
commented
Nov 2, 2023
carlossanlop
removed
the
NO-MERGE
carlossanlop
changed the title
ericstj
reviewed
Nov 2, 2023
ViktorHofer
reviewed
Nov 2, 2023
carlossanlop
force-pushed
the
LibrariesXUnitLogChecker
branch
from
143dad8
to
7eaf88c
Compare
|
All the remaining observations I had have already been pointed out in the review. So, it looks good to me now. |
This was referenced Nov 14, 2023
|
@ViktorHofer I addressed your latest comment (remove unused envvar property defined outside of the condition). I only need a sign-off, and remove the temporary change that causes the crash and skips unrelated CIs, then I can merge if the CI is green in the final run. |
hoyosjs
approved these changes
Nov 14, 2023
|
|
||
| <!-- For enabling the use of XUnitLogChecker in coreclr and libraries test runs. --> | ||
| <IsXUnitLogCheckerSupported Condition="'$(IsXUnitLogCheckerSupported)' == ''">false</IsXUnitLogCheckerSupported> | ||
| <IsXUnitLogCheckerSupported Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(TestNativeAot)' != 'true' and '$(TestRunNamePrefixSuffix)' != 'NativeAOT_Release' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi' and '$(TargetOS)' != 'ios' and '$(TargetOS)' != 'iossimulator' and '$(TargetOS)' != 'tvos' and '$(TargetOS)' != 'tvossimulator' and '$(TargetOS)' != 'maccatalyst' and '$(TargetOS)' != 'android'">true</IsXUnitLogCheckerSupported> |
There was a problem hiding this comment.
Do you need both in that case? Also, runtime flavor should remove a lot of the TargetOS ones.
carlossanlop
commented
Nov 14, 2023
… special case Darwin
carlossanlop
commented
Nov 14, 2023
carlossanlop
commented
Nov 14, 2023
carlossanlop
commented
Nov 14, 2023
carlossanlop
removed
the
NO-MERGE
3 tasks
|
@carlossanlop This broke native AOT outer loop runs. error : Correlation Payload 'D:\a_work\1\s\artifacts\bin\XUnitLogChecker' not found. [D:\a_work\1\s\src\libraries\sendtohelixhelp.proj] Could you please take a look asap? |
carlossanlop
added a commit
that referenced
this pull request
Nov 15, 2023
This reverts commit d561f39.
carlossanlop
added a commit
that referenced
this pull request
Nov 15, 2023
carlossanlop
added a commit
to carlossanlop/runtime
that referenced
this pull request
Nov 16, 2023
Libraries CI failures that generate dumps will now show the dump output in the console log itself.
carlossanlop
added a commit
to carlossanlop/runtime
that referenced
this pull request
Nov 28, 2023
Libraries CI failures that generate dumps will now show the dump output in the console log itself.
carlossanlop
added a commit
that referenced
this pull request
Nov 29, 2023
…OT tests (#94868) * Add XUnitLogChecker to log libraries dumps (#93906) Libraries CI failures that generate dumps will now show the dump output in the console log itself. * Change NativeAOT condition * Pass the global property set to false in the post build step. * Address suggestion: - Avoid using yml extraHelixArguments. - Add the new embedded SetCommands optional section in runner scripts. - Set __IsXUnitLogCheckerSupported in tests.targets as SetScriptCommand items instead of directly in sendtohelixhelp.proj. * Only add XUnitLogChecker as HelixPayload if its directory is found. Whether it was built or not has already been decided before, and the runner scripts know when to execute it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.