-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibraryImportGenerator unit test segfault illegal memory access #89054
Comments
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsError Blob{
"ErrorMessage": "exit code 139 means SIGSEGV Illegal memory access. Deref invalid pointer, overrunning buffer, stack overflow etc. Core dumped.",
"BuildRetry": false,
"ErrorPattern": "",
"ExcludeConsoleLog": true
} Reproduction Steps
Known issue validationBuild: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=342413 ReportSummary
|
@jkoritzinsky and @jtschuster This seems a bit odd. The generator is deterministic, so why aren't we seeing this more regularly or in the recent CI? Perhaps this is the non-determinism for A/V, but I'm surprised we haven't seen this before. |
The unit tests are all managed code I think. Was this something with us, or something with the runtime? |
That is the question. My initial guess here would be we are generating something bad. |
Generating something bad shouldn't cause a segfault unless we run the code, right? And I don't think we run generated code in the unit tests. |
Ah. I thought we run some of that code. Okay. |
Yeah we don't run any generated code in the unit tests. We only generate the code and then use the Roslyn APIs to inspect it. We only run the code in the "integration" tests (ie LibraryImportGenerator.Tests) |
I am seeing this failure affecting also
|
Yes, it is possible that this is the same failure. |
I've successfully got a Native AOT crash dump, with working symbols, on Linux for this. Download https://microsoft-my.sharepoint.com/:u:/p/angocke/Eaj2iJxJzItEgs8mngNfxZ0B081M0ipe2Q9ucGKiK80SFQ?e=hfCpNT for a zip with all the necessary bits |
@AaronRobinsonMSFT @jtschuster Could you take a look while Jeremy's out? |
@agocke The above link is for a failure in |
oh, do those tests not use the generor? OK, this must just be catching extra stuff |
Adjusted the error message, hopefully this will catch only LibraryImportGenerator segfaults now |
removing blocking-clean-ci as it has not failed in 30 days
|
I think it's worth closing this. Whatever was causing the LibraryImportGenerator failures looks more likely to be a runtime instability problem that has been resolved. |
Error Blob
Reproduction Steps
main
PR: Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280Libraries Test Run release coreclr osx x64 Debug
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=466877
Error message validated:
Segmentation fault .+ LibraryImportGenerator
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 11/16/2023 9:57:52 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: