Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing win-arm64 JIT tests #93451

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Oct 13, 2023

Disable these while we investigate what happened.

Related: #93424, #93441, #93442, #93443, #93444

Disable these while we investigate what happened.
@ghost ghost assigned jakobbotsch Oct 13, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 13, 2023
@ghost
Copy link

ghost commented Oct 13, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable these while we investigate what happened.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch jakobbotsch merged commit 1e8379d into dotnet:main Oct 13, 2023
98 of 101 checks passed
@jakobbotsch jakobbotsch deleted the disable-failing-jit-tests branch October 13, 2023 13:14
@BruceForstall
Copy link
Member

fwiw, my theory is a new MSVC compiler was picked up yesterday that has a bug, or exposes a bug in coreclr or JIT. Note that release/7.0 pipeline failed the same tests yesterday.

@jakobbotsch
Copy link
Member Author

@BruceForstall That's right, I've already root caused it in #93442 (comment)

@jakobbotsch
Copy link
Member Author

We need to revert the compiler upgrade or find a workaround. We can probably work around it by writing the logic in that function in a different, more convoluted way.

jkotas added a commit to jkotas/runtime that referenced this pull request Oct 14, 2023
jkotas added a commit that referenced this pull request Oct 15, 2023
* Revert "Disable value_numbering_checked_arithmetic_with_constants_ro (#93507)"

This reverts commit 28cf63f.

* Revert "Disable failing win-arm64 JIT tests (#93451)"

This reverts commit 1e8379d.

* Workaround for #93442
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants