Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable value_numbering_checked_arithmetic_with_constants_ro #93507

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Disable value_numbering_checked_arithmetic_with_constants_ro #93507

merged 1 commit into from
Oct 14, 2023

Conversation

BruceForstall
Copy link
Member

Tracking: #93506

@ghost ghost assigned BruceForstall Oct 14, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 14, 2023
@BruceForstall
Copy link
Member Author

@jakobbotsch @dotnet/jit-contrib PTAL

@ghost
Copy link

ghost commented Oct 14, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Tracking: #93506

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Oct 14, 2023
Closed
@BruceForstall BruceForstall merged commit 28cf63f into dotnet:main Oct 14, 2023
98 of 101 checks passed
@BruceForstall BruceForstall deleted the DisableFailingCheckedArithTest branch October 14, 2023 17:24
jkotas added a commit to jkotas/runtime that referenced this pull request Oct 14, 2023
@jkotas
Revert "Disable value_numbering_checked_arithmetic_with_constants_ro (d…
05c08af 
…otnet#93507)"

This reverts commit 28cf63f.
jkotas added a commit that referenced this pull request Oct 15, 2023
@jkotas
Workaround for #93442 (#93523)
139f45e 
* Revert "Disable value_numbering_checked_arithmetic_with_constants_ro (#93507)"

This reverts commit 28cf63f.

* Revert "Disable failing win-arm64 JIT tests (#93451)"

This reverts commit 1e8379d.

* Workaround for #93442
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @jakobbotsch