Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include TypeNameBuilder.cs from CoreLib instead of copying the file over #89144

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Jul 18, 2023

Apply feedback from #88503 (comment): Include TypeNameBuilder.cs from CoreLib instead of copying the file into System.Reflection.Emit

@ghost
Copy link

ghost commented Jul 18, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Apply feedback from #88503 (comment): Include TypeNameBuilder.cs from CoreLib instead of copying the file into System.Reflection.Emit

Author: buyaa-n
Assignees: buyaa-n
Labels:

area-System.Reflection.Emit

Milestone: -

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Jul 25, 2023

The failures unrelated, merging

@buyaa-n buyaa-n merged commit 6e79f94 into dotnet:main Jul 25, 2023
@buyaa-n buyaa-n deleted the typenamebuilder branch July 25, 2023 23:23
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants