Add EnumBuilder implementation and other changes

[buyaa-n]

Contributes to #62956

Tested AB.Save implementation with TlbImp3.exe with a sample *.tlb files. Adding/updating following based on the test result:

• Add implementation for TypeBuilderImpl.FullName ( this needed TypeNameBuilder which copied from Corelib)
• Add implementation for TypeBuilderImpl.CreateTypeInfoCore() - for now just returning the TypeBuilderImp itself, might need some update after IL implementation added;
• Added EnumBuiderImpl, mostly using TypeBuilderImpl code for writing to file
• EnumBuiderImpl needs FieldBuilderImp.SetConstantCore(object? defaultValue) implementation, so added it

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Contributes to https://github.com/dotnet/runtime/issues/

Tested AB.Save implementation with TlbImp3.exe with a sample *.tlb files. Adding/updating following based on the test result:

• Add implementation for TypeBuilderImpl.FullName ( this needed TypeNameBuilder which copied from Corelib)
• Add implementation for TypeBuilderImpl.CreateTypeInfoCore() - for now just returning the TypeBuilderImp itself, might need some update after IL implementation added;
• Added EnumBuiderImpl, mostly using TypeBuilderImpl code for writing to file
• EnumBuiderImpl needs FieldBuilderImp.SetConstantCore(object? defaultValue) implementation, so added it

Author:	buyaa-n
Assignees:	buyaa-n
Labels:	area-System.Reflection.Emit
Milestone:	-

[steveharter]

LGTM; some minor nits\questions.

[steveharter]

I wonder if we need the differentiation here - the one above may be acceptable for null as well, plus considering there is only one case for the null check.

[buyaa-n]

Yes, the above acceptable, but it might be cleared than the above, also the exception messages and throwing logic copied from corelib, it might be better to be consistent with corelib messaging, let me know if you think otherwise.

[buyaa-n]

All failures are not related and known

[jkotas]

This file is line-to-line identical to https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/TypeNameBuilder.cs except for deleted comment and unused method.

Would it be better to just include the CoreLib in the .csproj file instead of copying it the file over?

[buyaa-n]

This file is line-to-line identical to https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/TypeNameBuilder.cs except for deleted comment and unused method.

Right, and I mentioned that in the description.

Would it be better to just include the CoreLib in the .csproj file instead of copying it the file over?

Was not aware of that was an option, I will try that out with my next PR which probably will not happen in .NET 8.0, would you like to update that within .NET 8?

[jkotas]

We have number of places where we borrow CoreLib code to avoid copying it around. Look for <Compile Include="$(CoreLibSharedDir)System.... This pattern is typically used for down-level configs, I do not see a problem with doing the same here.

This does not need to be in .NET 8. However, I do prefer smaller more frequent PRs that do just one thing - they are much easier to review and merge.