Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run NativeAOT tests when ILLink changes #88934

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Run NativeAOT tests when ILLink changes #88934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,11 @@ extends:
buildArgs: -s clr.aot+clr.iltools+libs+clr.toolstests -c $(_BuildConfig) -test
enablePublishTestResults: true
testResultsFormat: 'xunit'
# We want to run AOT tests when illink changes because there's share code and tests from illink which are used by AOT
condition: >-
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange'], true),
eq(variables['isRollingBuild'], true))

# Build Mono AOT offset headers once, for consumption elsewhere
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/ArrayDataFlow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ static void TestArrayWithInitializerMultipleElementsStaticType ()
Type[] arr = new Type[] { typeof (TestType), typeof (TProperties), typeAll };
arr[0].RequiresAll ();
arr[1].RequiresPublicProperties ();
arr[1].RequiresPublicFields (); // Should warn
arr[1].RequiresPublicFields (); // Should warn - member types mismatch
arr[2].RequiresAll ();
arr[3].RequiresPublicMethods (); // Should warn - unknown value at this index
}
Expand Down