Run NativeAOT tests when ILLink changes

[vitek-karas]

NativeAOT uses code from ILLinker - specifically we share lot of tests. So if these change we want to make sure it didn't break their usage in NativeAOT.

The comment change in the tests is to trigger this new rule in the CI - but we can keep the comment regardless.

This was found by #88678 which broke NativeAOT (#88922) because the CI for #88678 didn't run NativeAOT tests.

[ghost]

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

NativeAOT uses code from ILLinker - specifically we share lot of tests. So if these change we want to make sure it didn't break their usage in NativeAOT.

The comment change in the tests is to trigger this new rule in the CI - but we can keep the comment regardless.

This was found by #88678 which broke NativeAOT (#88922) because the CI for #88678 didn't run NativeAOT tests.

Author:	vitek-karas
Assignees:	vitek-karas
Labels:	area-NativeAOT-coreclr
Milestone:	8.0.0

[radical]

When do you run the NativeAOT tests?

For wasm we run only System.Runtime.Tests on PRs, because the full run is resource heavy. Currently, you need to run runtime-wasm specifically to get all the AOT tests to run. But I'm wondering now if we can follow the same idea and run these in runtime on PRs - but 1. smoke only by default for wasm; 2. all - if sure that it's needed.

That should catch other instances of illinker changes that might break stuff in wasm.

[agocke]

LGTM

[agocke]

@radical Right now we only run the tests when Native AOT or something else in the coreclr tools directory changes (which is mostly native aot and crossgen2). This also runs the tests when ILLink changes, but this is similarly low traffic.

Also, this is just the smoke tests. The full suite is in runtime-extra-platforms and doesn't run by default in PR.

[vitek-karas]

Also - I should have been more specific. This will run the NativeAOT Unit tests - so tests which were written directly for the compiler. It will NOT run the AOTed libraries tests for example.

[radical]

Thanks, that helps! 👍

[vitek-karas]

All failures are known and the desired lag did run in CI.