Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable IOPack, IOEnqueue, and IODequeue on Windows #88894

Merged
merged 22 commits into from
Aug 9, 2023
Merged

Enable IOPack, IOEnqueue, and IODequeue on Windows #88894

merged 22 commits into from
Aug 9, 2023

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Jul 14, 2023 •
edited
Loading

Fixes #87020

@eduardo-vp eduardo-vp requested a review from LakshanF July 14, 2023 04:21
@ghost ghost assigned eduardo-vp Jul 14, 2023
@ghost
Copy link

ghost commented Jul 14, 2023

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: eduardo-vp
Assignees: eduardo-vp
Labels:

area-System.Threading
Milestone: -

This was referenced Jul 14, 2023
Open
Closed
@LakshanF LakshanF requested a review from VSadov July 17, 2023 11:36
@kouvel kouvel mentioned this pull request Jul 20, 2023
Closed
@kouvel
Copy link
Member

kouvel commented Jul 20, 2023

The IOEnqueue and IODequeue events are currently also raised in the portable implementation for registered waits. An IOEnqueue event is raised when the wait is registered, and an IODequeue event is raised just before each wait completion is processed. Could raise those for the Windows thread pool implementation similarly too.

@build-analysis build-analysis bot mentioned this pull request Aug 2, 2023
Open
@eduardo-vp eduardo-vp marked this pull request as ready for review August 3, 2023 00:03
This was referenced Aug 3, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Aug 3, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Aug 3, 2023
Open
LakshanF
LakshanF approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from the NativeAOT perspective. Thanks for doing this work!

@build-analysis build-analysis bot mentioned this pull request Aug 5, 2023
Closed
kouvel
kouvel reviewed Aug 7, 2023
View reviewed changes
...raries/System.Private.CoreLib/src/System/Threading/RegisteredWaitHandle.WindowsThreadPool.cs Outdated Show resolved Hide resolved
...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs Outdated Show resolved Hide resolved
...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs Outdated Show resolved Hide resolved
src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated Show resolved Hide resolved
src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated Show resolved Hide resolved
src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated Show resolved Hide resolved
...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs Outdated Show resolved Hide resolved
@LakshanF LakshanF mentioned this pull request Aug 8, 2023
Closed
kouvel
kouvel reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM, thanks!

...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs Show resolved Hide resolved
@eduardo-vp eduardo-vp merged commit 41f58f6 into dotnet:main Aug 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kouvel kouvel kouvel approved these changes

@LakshanF LakshanF LakshanF approved these changes

@VSadov VSadov Awaiting requested review from VSadov

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees

@eduardo-vp eduardo-vp

Labels
area-System.Threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable relevant thread pool events in Windows
3 participants
@eduardo-vp @kouvel @LakshanF