Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nativeruntimeeventsource test fails due to missing metadata #90021

Closed
LakshanF opened this issue Aug 4, 2023 · 7 comments
Closed

nativeruntimeeventsource test fails due to missing metadata #90021

LakshanF opened this issue Aug 4, 2023 · 7 comments
Assignees
@LakshanF
Labels
area-NativeAOT-coreclr
Milestone
9.0.0

Comments

@LakshanF
Copy link
Contributor

LakshanF commented Aug 4, 2023

Required event data payload types need to be preserved, asserts here.

00 00000008c32fef60 00007ff7c0783de4 nativeruntimeeventsource!S_P_CoreLib_System_Diagnostics_Tracing_EventPipePayloadDecoder__DecodePayload+0x5f [src\libraries\System.Private.CoreLib\src\System\Diagnostics\Tracing\EventPipePayloadDecoder.cs @ 19]
01 00000008c32ff7a0 00007ff7c0789ad4 nativeruntimeeventsource!S_P_CoreLib_System_Diagnostics_Tracing_NativeRuntimeEventSource__ProcessEvent+0xc4 [src\libraries\System.Private.CoreLib\src\System\Diagnostics\Tracing\NativeRuntimeEventSource.cs @ 60]
02 00000008c32ff830 00007ff7c073cdf1 nativeruntimeeventsource!S_P_CoreLib_System_Diagnostics_Tracing_EventPipeEventDispatcher__DispatchEventsToEventListeners+0x184 [src\libraries\System.Private.CoreLib\src\System\Diagnostics\Tracing\EventPipeEventDispatcher.cs @ 188]
03 00000008c32ff960 00007ff7c0850787 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task__InnerInvoke+0x71 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2399]
04 00000008c32ff9b0 00007ff7c072efcf nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task___c____cctor_b__281_0+0x57 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2387]
05 00000008c32ffa00 00007ff7c073cb50 nativeruntimeeventsource!S_P_CoreLib_System_Threading_ExecutionContext__RunInternal+0x11f [src\libraries\System.Private.CoreLib\src\System\Threading\ExecutionContext.cs @ 179]
06 00000008c32ffab0 00007ff7c073c7dd nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task__ExecuteWithThreadLocal+0x2c0 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2345]
07 00000008c32ffc30 00007ff7c08509a9 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task__ExecuteEntryUnsafe+0x7d [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2283]
08 00000008c32ffc80 00007ff7c084b16b nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_ThreadPoolTaskScheduler___c____cctor_b__10_0+0x59 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\ThreadPoolTaskScheduler.cs @ 35]
09 00000008c32ffcc0 00007ff7c084b098 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread_StartHelper__RunWorker+0xbb [src\libraries\System.Private.CoreLib\src\System\Threading\Thread.cs @ 82]
0a 00000008c32ffd20 00007ff7c072afeb nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread_StartHelper__Run+0xa8 [src\libraries\System.Private.CoreLib\src\System\Threading\Thread.cs @ 54]
0b 00000008c32ffd80 00007ff7c072b9e2 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread__StartThread+0x10b [src\coreclr\nativeaot\System.Private.CoreLib\src\System\Threading\Thread.NativeAot.cs @ 447]
0c 00000008c32ffe10 00007ffd418526ad nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread__ThreadEntryPoint+0x22 [src\coreclr\nativeaot\System.Private.CoreLib\src\System\Threading\Thread.NativeAot.Windows.cs @ 224]
0d 00000008c32ffe60 00007ffd425caa68 KERNEL32!BaseThreadInitThunk+0x1d
0e 00000008c32ffe90 0000000000000000 ntdll!RtlUserThreadStart+0x28

sdfsf
@LakshanF LakshanF added this to the 9.0.0 milestone Aug 4, 2023
@LakshanF LakshanF added this to AppModel Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Required event data payload types need to be preserved, asserts here.

00 00000008c32fef60 00007ff7c0783de4 nativeruntimeeventsource!S_P_CoreLib_System_Diagnostics_Tracing_EventPipePayloadDecoder__DecodePayload+0x5f [src\libraries\System.Private.CoreLib\src\System\Diagnostics\Tracing\EventPipePayloadDecoder.cs @ 19]
01 00000008c32ff7a0 00007ff7c0789ad4 nativeruntimeeventsource!S_P_CoreLib_System_Diagnostics_Tracing_NativeRuntimeEventSource__ProcessEvent+0xc4 [src\libraries\System.Private.CoreLib\src\System\Diagnostics\Tracing\NativeRuntimeEventSource.cs @ 60]
02 00000008c32ff830 00007ff7c073cdf1 nativeruntimeeventsource!S_P_CoreLib_System_Diagnostics_Tracing_EventPipeEventDispatcher__DispatchEventsToEventListeners+0x184 [src\libraries\System.Private.CoreLib\src\System\Diagnostics\Tracing\EventPipeEventDispatcher.cs @ 188]
03 00000008c32ff960 00007ff7c0850787 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task__InnerInvoke+0x71 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2399]
04 00000008c32ff9b0 00007ff7c072efcf nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task___c____cctor_b__281_0+0x57 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2387]
05 00000008c32ffa00 00007ff7c073cb50 nativeruntimeeventsource!S_P_CoreLib_System_Threading_ExecutionContext__RunInternal+0x11f [src\libraries\System.Private.CoreLib\src\System\Threading\ExecutionContext.cs @ 179]
06 00000008c32ffab0 00007ff7c073c7dd nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task__ExecuteWithThreadLocal+0x2c0 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2345]
07 00000008c32ffc30 00007ff7c08509a9 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_Task__ExecuteEntryUnsafe+0x7d [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\Task.cs @ 2283]
08 00000008c32ffc80 00007ff7c084b16b nativeruntimeeventsource!S_P_CoreLib_System_Threading_Tasks_ThreadPoolTaskScheduler___c____cctor_b__10_0+0x59 [src\libraries\System.Private.CoreLib\src\System\Threading\Tasks\ThreadPoolTaskScheduler.cs @ 35]
09 00000008c32ffcc0 00007ff7c084b098 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread_StartHelper__RunWorker+0xbb [src\libraries\System.Private.CoreLib\src\System\Threading\Thread.cs @ 82]
0a 00000008c32ffd20 00007ff7c072afeb nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread_StartHelper__Run+0xa8 [src\libraries\System.Private.CoreLib\src\System\Threading\Thread.cs @ 54]
0b 00000008c32ffd80 00007ff7c072b9e2 nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread__StartThread+0x10b [src\coreclr\nativeaot\System.Private.CoreLib\src\System\Threading\Thread.NativeAot.cs @ 447]
0c 00000008c32ffe10 00007ffd418526ad nativeruntimeeventsource!S_P_CoreLib_System_Threading_Thread__ThreadEntryPoint+0x22 [src\coreclr\nativeaot\System.Private.CoreLib\src\System\Threading\Thread.NativeAot.Windows.cs @ 224]
0d 00000008c32ffe60 00007ffd425caa68 KERNEL32!BaseThreadInitThunk+0x1d
0e 00000008c32ffe90 0000000000000000 ntdll!RtlUserThreadStart+0x28

sdfsf

Author: LakshanF
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: 9.0.0

@LakshanF
Copy link
Contributor Author

LakshanF commented Aug 8, 2023

This test use ThreadPool events, ThreadPoolIOEnqueue, ThreadPoolIODequeue, ThreadPoolIOPack (eventIDs 63, 64, 65). Revisit after #88894 is merged.

@LakshanF LakshanF self-assigned this Aug 11, 2023
@LakshanF
Copy link
Contributor Author

This is likely a test issue since the same events are passing in native AOT for the eventlistenerthreadpool test.

@LakshanF
Copy link
Contributor Author

The thread pool event, ThreadPoolIOWork (id=64), doesn't get fired now in Windows.

@MichalStrehovsky
Copy link
Member

The thread pool event, ThreadPoolIOWork (id=64), doesn't get fired now in Windows.

If this event is specific to the portable threadpool, we'd not use that on Windows - native AOT defaults to the native OS-provided threadpool. You could probably quickly check by adding <UseWindowsThreadPool>false</UseWindowsThreadPool> to a propertygroup in the project to force using the portable threadpool.

@LakshanF
Copy link
Contributor Author

If this event is specific to the portable threadpool, we'd not use that on Windows - native AOT defaults to the native OS-provided threadpool. You could probably quickly check by adding <UseWindowsThreadPool>false</UseWindowsThreadPool> to a propertygroup in the project to force using the portable threadpool.

ThreadPoolIOWork doesn't seem to be fired with UseWindowsThreadPool set to false as well. There are additional events - ContentionXXX, ThreadPoolWorkerThreadStart, ThreadPoolMinMaxThreads - that gets fired but not ThreadPoolIOWork.

@LakshanF
Copy link
Contributor Author

Re-opened #87020 to track this.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LakshanF LakshanF

Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@LakshanF @MichalStrehovsky