-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-staging] Microsoft.NETCore.Platforms: support adding rids with '-' in the base part. #86282
[release/7.0-staging] Microsoft.NETCore.Platforms: support adding rids with '-' in the base part. #86282
Conversation
… part. Currently when trying to add a rid like 'linux-musl-x64' the rid is not understood to be base = 'linux-musl', arch = 'x64'. Instead the parser considers a potential optional qualifier. This causes the rid to be parsed as base = 'linux', arch = 'musl', and qualifier = 'x64'. We know the rids being added won't have a qualifier. If we take this into account while parsing, we can parse the rid correctly.
…ection.cs Co-authored-by: Eric StJohn <[email protected]>
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #84413 to release/7.0-staging /cc @carlossanlop @tmds Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
This change requires Microsoft.NETCore.Platforms.csproj OOB package authoring changes but they aren't needed in this PR if we merge this other one for the June release, which already contains such changes: #84984 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm treating this as tell-mode since the affected cs file is a build task, so not customer facing. I notified Tactics anyway just so they were informed. |
Backport of #84413 to release/7.0-staging
/cc @carlossanlop @tmds
Per @tmds
Customer impact
#77508 was merged, but its installer counterpart (dotnet/installer#14816) was NAKed due to safety concerns. This revealed a limit with Microsoft.NETCore.Platforms parsing of RID. Thus, build of source-build on linux-musl platforms is currently broken. A few approches on installer side can be implemented as workarounds, but ideally the fix should be on runtime side.
This also unblocks dotnet/installer#13074.
Testing
Risk
Low, there were limited changes in that code between
release/6.0
andmain
.cc @tmds @ayakael