Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ubuntu 22.10 kinetic kudu RIDs for .NET 7 #84984

Merged
merged 2 commits into from
May 16, 2023
Merged

Add Ubuntu 22.10 kinetic kudu RIDs for .NET 7 #84984

merged 2 commits into from
May 16, 2023

Conversation

dviererbe
Copy link
Contributor

Related to #84974

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 18, 2023
@ghost
Copy link

ghost commented Apr 18, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #84974

Author: dviererbe
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@dviererbe
Copy link
Contributor Author

@dotnet-policy-service agree company="Canonical"

This was referenced Apr 18, 2023
Closed
Closed
Closed
@carlossanlop
Copy link
Member

@dviererbe please retarget your PR to release/7.0-staging, per these instructions: https://github.com/dotnet/runtime/blob/release/7.0-staging/docs/project/library-servicing.md

@carlossanlop carlossanlop requested a review from wfurt May 3, 2023 16:27
@carlossanlop carlossanlop changed the base branch from release/7.0 to release/7.0-staging May 3, 2023 16:28
@wfurt
Copy link
Member

wfurt commented May 3, 2023

do we have PR for main? We usually start with that.
Also it seems like 23.10 is also announced https://www.omgubuntu.co.uk/2023/04/ubuntu-23-10-codename-revealed
I'm wondering we we could/should do them together (don't need to)

@build-analysis build-analysis bot mentioned this pull request May 3, 2023
Closed
carlossanlop
carlossanlop requested changes May 4, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a PR merged in main first.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 4, 2023
@dviererbe
Copy link
Contributor Author

Sorry for the long delay.

@wfurt I think we can add mantic too I will prepare this.
@carlossanlop I thought this change is an exception, because Microsoft plans to step away from RIDs. See #83246 I will prepare a PR for main.

Same applies for the .NET 6 PR #84983

@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label May 5, 2023
@wfurt
Copy link
Member

wfurt commented May 5, 2023

and yes, the desire is there as keeping up with all Linux releases is .....

dviererbe added a commit to dviererbe/dotnet-runtime that referenced this pull request May 8, 2023
@dviererbe
Add Ubuntu Kinetic 22.10 and Mantic 23.10 RIDs
9c2e776 
Adds the Runtime Identifiers (RIDs) for Ubuntu 22.10 Kinetic Kudu and
the recently announced Ubuntu 23.10 Mantic Minotaur.

Related to dotnet#84974, dotnet#84983, dotnet#84984
@dviererbe dviererbe mentioned this pull request May 8, 2023
Merged
wfurt pushed a commit that referenced this pull request May 15, 2023
@dviererbe
Add Ubuntu Kinetic 22.10 and Mantic 23.10 RIDs (#85912)
107aeac 
Adds the Runtime Identifiers (RIDs) for Ubuntu 22.10 Kinetic Kudu and
the recently announced Ubuntu 23.10 Mantic Minotaur.

Related to #84974, #84983, #84984
carlossanlop
carlossanlop approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the main change.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label May 15, 2023
@carlossanlop
Copy link
Member

@dviererbe FYI I added a missing change in the Microsoft.NETCore.Platforms.csproj file that ensures it gets built for servicing.

wfurt
wfurt approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced May 15, 2023
Merged
Merged
@wfurt wfurt mentioned this pull request May 15, 2023
Merged
@carlossanlop carlossanlop merged commit eb3160d into dotnet:release/7.0-staging May 16, 2023
@carlossanlop carlossanlop mentioned this pull request May 16, 2023
Merged
This was referenced May 16, 2023
Merged
Merged
@rbhanda rbhanda mentioned this pull request May 18, 2023
Closed
12 tasks
@radical radical mentioned this pull request Jun 15, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dviererbe @carlossanlop @wfurt