-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify -z notext on linux-musl-x86 and riscv64 #83682
Conversation
Tagging subscribers to this area: @hoyosjs Issue Details
Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default. Ref: #83509 (comment)
|
Very nice! Many thanks for upstreaming these. |
We may have to extend the condition to include I'm testing #82294, and encountering similar error that I've tried extending the condition, but the error still persists when linking |
f9f7812
to
65877a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX
. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
noti to #84834 |
Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.
Ref: #83509 (comment)
cc @ayakael