Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calling convention modifiers from cpuid sig #83672

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Mar 20, 2023

Failure on linux-musl-x86:

/runtime/src/coreclr/vm/cgensys.h:107:26: error: stdcall calling convention is not supported on builtin function [-Werror,-Wignored-attributes]

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 20, 2023
@am11 am11 requested a review from jkotas March 20, 2023 16:39
src/coreclr/vm/cgensys.h Outdated Show resolved Hide resolved
src/coreclr/vm/cgensys.h Outdated Show resolved Hide resolved
> /runtime/src/coreclr/vm/cgensys.h:107:26: error: stdcall calling convention is not supported on builtin function [-Werror,-Wignored-attributes]
@am11 am11 changed the title Fix callconv for linux-x86 Remove calling convention modifiers from cpuid sig Mar 20, 2023
@ayakael
Copy link
Contributor

ayakael commented Mar 20, 2023

Passes on my alpine-x86 cross-cI: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1475

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas closed this Mar 21, 2023
@jkotas jkotas reopened this Mar 21, 2023
@jkotas jkotas merged commit 8e8ab0c into dotnet:main Mar 21, 2023
@am11 am11 deleted the patch-17 branch March 21, 2023 03:20
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants